Change basin rendering to a tile-based approach#9819
Open
hadron13 wants to merge 5 commits intoCreators-of-Create:mc1.21.1/devfrom
Open
Change basin rendering to a tile-based approach#9819hadron13 wants to merge 5 commits intoCreators-of-Create:mc1.21.1/devfrom
hadron13 wants to merge 5 commits intoCreators-of-Create:mc1.21.1/devfrom
Conversation
…mpBlock, aswell as for encased pipe checking.
VoidLeech
added
area: rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way fluids are rendered in a basin for a tiled method which makes more logical sense than the current method.
Current approach:
Tile based:
A tiny video demo has been sent in #devchat Create Development thread in Create's Discord server
This also opens up possibility for a configuration to expand the number of fluids a basin can hold, this can prove to be very helpful to addon & modpack creators where it allows recipes with more than 2 fluid ingredients/outputs.
It does have an issue not present in the current implementation: sometimes fluids will reorganize in a non-linear fashion.