Repository navigation
Conversation
VoidLeech
added
pr type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After crashing repeatedly (see #10809) trying to use pick-block near toolboxes, I hunted the problem down. Turns out that getPickedResult there :
Create/src/main/java/com/simibubi/create/content/equipment/toolbox/ToolboxHandlerClient.java
Line 77 in a927008
Can return null. I assume that is if the entity doesn't have a spawn egg. That is the case with Ars Nouveau pets, or the more annoying flying bows of the Balistasarian Bracer from Reliquified Ars Nouveau that gets in the way a lot. That explains the inconsistency of the crashes, it only happened when one of those bows passed in front of my camera at the wrong time.
The method itself is tagged @ Nullable so it's definitely a bug of Create, but it's an easy fix.