Get correct fluid requirement when filling items with stack size-aware capabilities#10351
Open
VoidLeech wants to merge 1 commit into
Open
Conversation
VoidLeech
added
pr type: fix
|
For some context, before 1.16 it was the standard for fluid capabilities to always require stack size 1, and larger stack sizes were considered to have no capability at all. On more recent versions, Thermal Series set the standard to treat higher stack sizes as filling the entire stack, so by convention for a variable sized fluid tank you just fill in increments of the stack size now. There was never a version where filling a stack of fluid containers of size greater than 1 was expected to just fill 1 of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - #10350