Datagen SimpleDatagenIngredient without wrapping in neoforge:compound#10223
Open
VoidLeech wants to merge 1 commit into
Open
Datagen SimpleDatagenIngredient without wrapping in neoforge:compound#10223VoidLeech wants to merge 1 commit into
VoidLeech wants to merge 1 commit into
Conversation
…ompound improves compatibility with Almost Unified for processing recipes generated through Create's datagen
VoidLeech
added
the
pr type: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the MapCodec for
Ingredient.Values, only when datagen is ran, so that we can use one of vanilla's private constructors and serialize non-registered items as if they were. At runtime we don't change anything and they're just resolved as normal Ingredients backed by an ItemValue.Marginally decreases file size (18.688 -> 18.681 kB on my machine) and should have slightly lower memory usage as well due to not having single ingredients wrapped in lists inside a CompoundIngredient.
Prevents issues like #10203 (comment) from popping up with recipes output from Create's datagen (api). Wouldn't resolve them for people using a compound ingredient with multiple options but I believe that'd require overhauling the entire recipe syntax.