Skip to content

feat: add support for prerelease and build fields in app version parsing #6354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kanwarujjaval
Copy link
Member

No description provided.

Copilot

This comment was marked as outdated.

@kanwarujjaval kanwarujjaval requested a review from Copilot June 27, 2025 11:36
Copilot

This comment was marked as outdated.

@kanwarujjaval kanwarujjaval requested a review from Copilot June 27, 2025 11:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for prerelease and build information in app version parsing by updating version extraction and reporting across multiple modules.

  • Added prerelease and build fields to crash reports.
  • Modified version parsing in common utilities to include prerelease data.
  • Updated user properties to incorporate new version parts and improved error handling when the format is invalid.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
plugins/crashes/api/api.js Adds prerelease and build values to crash report configuration and schema.
api/utils/common.js Updates semver coercion and parsing to include prerelease and build values.
api/parts/data/usage.js Incorporates prerelease and build fields into user properties and logs errors.
Comments suppressed due to low confidence (2)

api/parts/data/usage.js:1120

  • [nitpick] Consider aligning the naming of version fields across modules; for example, using 'app_version_release' instead of 'av_rel' can improve consistency with other parts of the codebase.
                userProps.av_rel = versionComponents.prerelease;

api/parts/data/usage.js:1124

  • [nitpick] Consider including expected version format details in the warning message to aid debugging.
                log.w("Invalid app version format: %s", params.qstring.metrics._app_version);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants