Claude/fix ulid v3 e2e outc0#1697
Closed
00o-sh wants to merge 843 commits into
Closed
Conversation
chore(deps): update dependency consola to v3.4.2
chore(deps): update dependency prettier to v3.7.4
This commit fixes all TypeScript errors introduced by upgrading @vue/tsconfig from 0.4.0 to 0.8.1. The new version enables stricter type checking with noUncheckedIndexedAccess, which requires proper null/undefined handling. Key changes: - Add noEmit: false to composite tsconfig files to fix build errors - Add proper null/undefined checks for array/object access throughout codebase - Fix potentially undefined values in VueUse hooks (keys.escape, keys.ctrl_k, etc.) - Add null guards for array element access in utility functions - Improve type safety in temperature converter, benchmark builder, and other tools All 138 unit tests pass and the production build succeeds.
chore(deps): update dependency unplugin-icons to v0.22.0
…ponents-0.x chore(deps): update dependency unplugin-vue-components to v0.28.0
Fix linting issues found in CI: - Convert randFromArray to function declaration (top-level functions require function keyword) - Fix ISO8601 regex backreference issue by replacing \17 with :? and removing contradictory lookahead - Preserve IPv4 regex empty alternative with eslint-disable comment (intentional for 0-9 matching) - Add null check for temperature converter input value All tests passing and linter satisfied.
…YP4uqDt5C3vWFPR34eaF chore(deps): update dependency @vue/tsconfig to v0.8.1
chore(deps): update dependency workbox-window to v7.4.0
chore(deps): update node.js to v20.19.6
…3.x) This commit addresses compatibility issues identified in PRs #338 and #347 by upgrading both TypeScript and vue-tsc together: - Upgrade TypeScript from 5.4.5 to 5.9.3 - Upgrade vue-tsc from ^1.8.1 to ^3.0.0 (resolves to 3.1.8) - Configure Renovate to group TypeScript toolchain updates together The previous separate upgrade attempts failed due to version incompatibilities: - PR #338: TypeScript 5.9.3 alone failed with vue-tsc 1.8.x (unsupported) - PR #347: vue-tsc 3.x alone failed with TypeScript 5.4.5 (missing libReplacement) Both dependencies are now updated together and all builds pass successfully.
…q8KnHPoYZ3VKD9r6z1uo chore(deps): update TypeScript toolchain (typescript 5.9.3 + vue-tsc 3.x)
fix(deps): update dependency @vicons/material to ^0.13.0
fix(deps): update dependency monaco-editor to ^0.55.0
This workflow provides automated reviews and recommendations for pull requests, including: - Workflow file validation when workflows are modified - Detection and reporting of failed workflow runs - Code quality observations (dependency changes, test changes, etc.) - General recommendations for PR checklist items - Specific guidance for troubleshooting common workflow failures The workflow posts a comprehensive comment on PRs with actionable recommendations without making any automatic changes to the code.
…flow-01AsVAp7uog8g35WoqK9AkVj Add automated PR review workflow
…ldx-action-digest chore(deps): update docker/setup-buildx-action digest to 8d2750c
chore(deps): update vue ecosystem to v3.5.26
chore(deps): pin dependency vitest to 4.0.16
…fig-6.x chore(deps): update dependency @antfu/eslint-config to v6.7.3
…s-1.x-lockfile chore(deps): update dependency libphonenumber-js to v1.12.33
fix(deps): update tiptap monorepo to v3.14.0
…hain chore(deps): update dependency vue-tsc to v3.2.1
chore(deps): update pnpm to v10.26.1
…ckfile chore(deps): update dependency vue-i18n to v11.2.7
The OTP code generator and PDF signature checker E2E tests were failing consistently with the page showing the homepage instead of the tool page, and elements timing out. While commit e7dc7b1 fixed a ref unwrapping issue and removed the networkidle wait (believing it was just masking the problem), the tests are still failing. This suggests there's an additional timing/loading issue beyond the ref unwrapping problem. Re-adding `waitUntil: 'networkidle'` to ensure the page and its JavaScript are fully loaded before the tests start interacting with the page. Fixes: - OTP code generator: All 4 tests (title check, secret hex computation, OTP generation, random secret generation) - PDF signature checker: Title check test
The PDF signature checker E2E test was failing because the component was trying to use <pdf-signature-details> without explicitly importing it. While unplugin-vue-components auto-imports most components, the pattern in this codebase is to explicitly import local sub-components within tools. Examples from other tools: - OTP tool: `import TokenDisplay from './token-display.vue'` - JSON diff: `import DiffsViewer from './diff-viewer/diff-viewer.vue'` - User agent parser: `import UserAgentResultCards from './user-agent-result-cards.vue'` The PDF component was relying on auto-import for a component in a subdirectory, causing it to fail to render and showing the homepage instead of the tool page. Also reverted the previous networkidle workaround commit since it wasn't addressing the root cause. Fixes E2E test failures for: - PDF signature checker: Title check test - (OTP tests should already be working from the ref unwrapping fix in e7dc7b1)
ESLint requires component names in templates to be PascalCase. Changed <pdf-signature-details> to <PdfSignatureDetails> to fix linting error.
…res-OUTC0 fix: re-add networkidle wait for OTP and PDF signature checker E2E tests
With ulid v3, the package provides separate exports for Node.js and browser environments. Without explicit configuration, Vite may not consistently resolve to the browser version, which could cause bundling and lazy-loading issues that affect E2E test timing. Changes: 1. Added 'ulid' to optimizeDeps.include to ensure it's pre-bundled 2. Added resolve.conditions with 'browser' first to prefer browser exports This ensures consistent module resolution and should fix E2E test failures when upgrading from ulid v2 to v3.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read |
Check notice
Code scanning / SonarCloud
Read permissions should be defined at the job level Low
|
|
||
| permissions: | ||
| contents: read | ||
| actions: write |
Check notice
Code scanning / SonarCloud
Write permissions should be defined at the job level Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.