[Feat] - Modularize data availability submission design #1743
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1743 +/- ##
============================================
+ Coverage 64.51% 64.59% +0.07%
- Complexity 1523 1524 +1
============================================
Files 396 404 +8
Lines 14382 14409 +27
Branches 1545 1550 +5
============================================
+ Hits 9279 9307 +28
Misses 4493 4493
+ Partials 610 609 -1
🚀 New features to boost your workflow:
|
kyzooghost
left a comment
kyzooghost
left a comment
There was a problem hiding this comment.
Nit - this PR is no longer a chore with a few thousands lines-of-code diff :)
contracts/local-deployments-artifacts/deployPlonkVerifierAndValidiumV1.ts
Outdated
Show resolved
Hide resolved
thedarkjester
changed the title
renamed the title |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| pauseTypeRoles, | ||
| unpauseTypeRoles, | ||
| defaultAdmin: validiumSecurityCouncil, | ||
| }, |
There was a problem hiding this comment.
Bug: Validium deployment script missing required shnarfProvider field
The Validium deployment script is missing the shnarfProvider field in the initialization data struct. The contract's initialize function expects BaseInitializationData with 11 fields including shnarfProvider as the last field (as shown in the ABI and VALIDIUM_INITIALIZE_SIGNATURE). The other deployment script deployPlonkVerifierAndValidiumV1.ts correctly includes shnarfProvider: ADDRESS_ZERO, but this hardhat deploy script omits it. This would cause deployment to fail due to ABI encoding mismatch.
| fallbackOperator: MultiCallAddress, | ||
| defaultAdmin: lineaRollupSecurityCouncil, | ||
| }, | ||
| MultiCallAddress, |
There was a problem hiding this comment.
Bug: LineaRollup deployment script missing required shnarfProvider field
The LineaRollup deployment script is missing the shnarfProvider field in the initialization data struct. The BaseInitializationData struct in ILineaRollupBase.sol requires 11 fields including shnarfProvider as the last field. The deployment script only passes 10 fields. The deployPlonkVerifierAndValidiumV1.ts shows the correct pattern with shnarfProvider: ADDRESS_ZERO. This would cause deployment to fail due to ABI encoding mismatch with the contract's initialize function.
This PR implements issue(s) #
Checklist
Note
Modularizes data availability (EIP-4844 and calldata), introduces a Validium L1 contract with shnarf provider, replaces fallback operator with liveness recovery, and updates roles/pause types, deployments, ABIs, and tests.
Eip4844BlobAcceptor,CalldataBlobAcceptor,ShnarfDataAcceptor,LocalShnarfProvider;LineaRollupnow composes these and usesshnarfProviderfor existence checks.LivenessRecovery(withsetLivenessRecoveryOperator,renounceRolerestriction) and removes fallback-operator logic; addsreinitializeV8gated by proxy admin.ILineaRollupBase,ILivenessRecovery; moves shared structs/errors; new errors for shnarf handling.Validium(with shnarf-based DA) + tests, ABI (ValidiumV1.0.abi), local artifacts, deploy scripts (03_deploy_Validium.ts, make targetdeploy-validium).ClaimMessageV1;L1MessageServicerefactored toL1MessageServiceBase; updates test helperTestL1MessageService.BLOB/CALLDATApause types withSTATE_DATA_SUBMISSION; introduces V6/V8 role/pause sets; adds rolesPAUSE/UNPAUSE_STATE_DATA_SUBMISSION_ROLE.livenessRecoveryOperator; addsshnarfProviderto base initialization; adjusts scripts, makefile, solcover, post-compile ABI export.Written by Cursor Bugbot for commit 8a4a28d. This will update automatically on new commits. Configure here.