[Feat] Automation Service #1589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
native-yield-operations/cronjob/src/core/services/contracts/IYieldManager.ts
Fixed
Show fixed
Hide fixed
native-yield-operations/cronjob/src/application/main/NativeYieldCronJobClient.ts
Fixed
Show fixed
Hide fixed
native-yield-operations/cronjob/src/clients/YieldManagerContractClient.ts
Fixed
Show fixed
Hide fixed
…ubmit latest vault report and unconditionally proceed to report yield
… submission - Add SHOULD_SUBMIT_VAULT_REPORT boolean config variable to config schema - Update config transformation to include shouldSubmitVaultReport - Modify YieldReportingProcessor to conditionally submit vault reports - Modify OssificationPendingProcessor to conditionally submit vault reports - Skip getLatestSubmitVaultReportParams when submission is disabled - Update bootstrap to pass config to both processors - Add comprehensive tests for new behavior
- Add YIELD_REPORT_POSITIVE_YIELD_THRESHOLD_WEI config variable - Add YIELD_REPORT_LIDO_PROTOCOL_FEE_THRESHOLD_WEI config variable - Both configs accept string/number/bigint and coerce to bigint - Both configs validate non-negative values - Update config transformation to include new fields - Update all test files to include new config variables - Add comprehensive documentation explaining OR logic between thresholds
jonesho
pushed a commit
that referenced
this pull request
Nov 24, 2025
* update version and changelog
…validation" This reverts commit ed6b23a.
kyzooghost
commented
Nov 24, 2025
| publicKey: v.publicKey, | ||
| validatorIndex: v.validatorIndex, | ||
| pendingWithdrawalAmount: pendingAmount, | ||
| withdrawableAmount: safeSub(safeSub(v.balance, pendingAmount), ONE_GWEI * 32n), |
Contributor
Author
There was a problem hiding this comment.
Added comment - // N.B We expect amounts from GraphQL API and Beacon Chain RPC URL to be in gwei units, not wei.
- Apply null coalescing before type assertion in VaultHubContractClient - Remove redundant type assertions and null checks - Fix missing newline at end of getNodeOperatorFeesPaidFromTxReceipt - Simplify return statements by moving default value handling earlier
kyzooghost
commented
Nov 24, 2025
| - name: Build and push postman image | ||
| uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 #v6.18.0 | ||
| if: ${{ env.PUSH_IMAGE == 'true' || github.event_name == 'workflow_dispatch' }} | ||
| # if: ${{ env.PUSH_IMAGE == 'true' || github.event_name == 'workflow_dispatch' }} |
Contributor
Author
There was a problem hiding this comment.
so I can push changes to devnet without merging this PR lol, I put it back to uncommented now
VGau
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist
Note
Introduces the Native Yield Automation Service and a new shared utils library, refactors Postman to use shared logging/metrics/API, and adds blockchain clients, retry/metrics plumbing, and extensive tests.
native-yield-operations/automation-service):ts-libs/linea-shared-utils):ExpressApiApplicationandWinstonLogger; addPostmanMetricsService.Written by Cursor Bugbot for commit 637a281. This will update automatically on new commits. Configure here.