Skip to content

Conversation

@DavePearce
Copy link
Collaborator

@DavePearce DavePearce commented Nov 21, 2025

This separates the mechanism for representing columns from trace generation itself, such that the representation can support different implementations and (critically) writing can be performed in memory.


Note

Replaces file-mapped buffer writing with a pluggable Column interface and bitwidth-based headers, updating open/metadata APIs, generated fields, and setters to support in-memory trace generation.

  • Java API and data model
    • Replace bytesPerElement with bitwidth in ColumnHeader and its construction.
    • Introduce Column interface (write(boolean|long|byte[])).
    • Change open(...) to open(Column[] columns); remove file/ByteBuffer-based open path.
    • Replace register fields from MappedByteBuffer to Column.
    • Replace addMetadata(...) with getMetaData() accessor.
  • Code generation changes
    • Column setters now call Column.write(...); remove custom byte/long putters and ByteBuffer position math.
    • fillAndValidateRow() writes default values via Column.write(...) instead of advancing by byte width.
    • Remove generation of file/IO header-writing logic and related helpers; simplify utilities (drop byte-width/register-count helpers).

Written by Cursor Bugbot for commit 922c1cf. This will update automatically on new commits. Configure here.

@DavePearce DavePearce linked an issue Nov 21, 2025 that may be closed by this pull request
@DavePearce DavePearce force-pushed the 1338-feat-switch-to-in-memory-trace-generation branch from 21d7740 to 4f1f69a Compare November 21, 2025 04:51
This separates the mechanism for representing columns from trace
generation itself, such that the representation can support different
implementations and (critically) writing can be performed in memory.
@DavePearce DavePearce force-pushed the 1338-feat-switch-to-in-memory-trace-generation branch from 4f1f69a to 922c1cf Compare November 21, 2025 06:48
@DavePearce DavePearce merged commit 76ae5f6 into main Nov 21, 2025
22 checks passed
@DavePearce DavePearce deleted the 1338-feat-switch-to-in-memory-trace-generation branch November 21, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: switch to in-memory trace generation

2 participants