Skip to content

Conversation

@DavePearce
Copy link
Collaborator

@DavePearce DavePearce commented Nov 21, 2025

This separates the mechanism for representing columns from trace generation itself, such that the representation can support different implementations and (critically) writing can be performed in memory.


Note

Replaces MappedByteBuffer-based writing with a Column interface and updates generated Java APIs (headers use bitwidth, new open signature, metadata accessor) to support in-memory trace generation.

  • Java codegen (classes/interfaces):
    • Introduce Column interface with write(boolean|long|byte[]) and make open accept Column[].
    • Change register fields from MappedByteBuffer to Column; make open public and initialize Column fields.
    • Update setters to use Column.write(...); remove low-level byte/long putter logic.
    • Default-fill missing values in fillAndValidateRow() via Column.write(...).
    • Adjust headers(...) to emit ColumnHeader with bitwidth (int) instead of bytesPerElement.
    • Replace addMetadata(...) with getMetaData() accessor.
  • Snippets/API:
    • Add javaColumn snippet; change javaColumnHeader to use bitwidth; simplify javaOpenSignature to public void open(Column[] columns);.
  • Utils:
    • Remove now-unused helpers (byteWidth, maxValueStr, getMaxRegisterIndex) and related imports.

Written by Cursor Bugbot for commit b436011. This will update automatically on new commits. Configure here.

@DavePearce DavePearce changed the title separate format implementation support in memory trace generation (cherry pick) Nov 21, 2025
@DavePearce DavePearce changed the title support in memory trace generation (cherry pick) feat: support in memory trace generation (cherry pick) Nov 21, 2025
This separates the mechanism for representing columns from trace
generation itself, such that the representation can support different
implementations and (critically) writing can be performed in memory.
@DavePearce DavePearce force-pushed the 1340-feat-cherry-pick-in-memory-trace-generation-1.1 branch from 681ac44 to b436011 Compare November 21, 2025 04:56
@DavePearce DavePearce merged commit 7915900 into v1.1-line Nov 21, 2025
16 checks passed
@DavePearce DavePearce deleted the 1340-feat-cherry-pick-in-memory-trace-generation-1.1 branch November 21, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants