feat: support in memory trace generation (cherry pick) #1341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the mechanism for representing columns from trace generation itself, such that the representation can support different implementations and (critically) writing can be performed in memory.
Note
Replaces MappedByteBuffer-based writing with a Column interface and updates generated Java APIs (headers use bitwidth, new open signature, metadata accessor) to support in-memory trace generation.
Columninterface withwrite(boolean|long|byte[])and makeopenacceptColumn[].MappedByteBuffertoColumn; makeopenpublic and initializeColumnfields.Column.write(...); remove low-level byte/long putter logic.fillAndValidateRow()viaColumn.write(...).headers(...)to emitColumnHeaderwithbitwidth(int) instead ofbytesPerElement.addMetadata(...)withgetMetaData()accessor.javaColumnsnippet; changejavaColumnHeaderto usebitwidth; simplifyjavaOpenSignaturetopublic void open(Column[] columns);.byteWidth,maxValueStr,getMaxRegisterIndex) and related imports.Written by Cursor Bugbot for commit b436011. This will update automatically on new commits. Configure here.