Skip to content

Conversation

@DavePearce
Copy link
Collaborator

@DavePearce DavePearce commented Nov 17, 2025

This adds the max3 utility for testing purposes


Note

Adds max3_u128 zkasm function to compute the max of three u128 values and integrates it into the test suite with extensive test vectors.

  • Assembly Utility:
    • Adds testdata/asm/util/max3.zkasm implementing max3_u128(arg1, arg2, arg3) -> res to return the maximum of three u128 values.
  • Testing:
    • Introduces Test_AsmUtil_Max3 in pkg/test/assembly_util_test.go to run asm/util/max3 across fields.
    • Adds comprehensive accept vectors in testdata/asm/util/max3.accepts.

Written by Cursor Bugbot for commit e9edc3a. This will update automatically on new commits. Configure here.

This adds the max3 utility for testing purposes
@DavePearce DavePearce linked an issue Nov 17, 2025 that may be closed by this pull request
@DavePearce DavePearce self-assigned this Nov 17, 2025
@DavePearce DavePearce merged commit 9728392 into main Nov 18, 2025
22 checks passed
@DavePearce DavePearce deleted the 1332-feat-add-max3-benchmark branch November 18, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add max3 benchmark

2 participants