feat: function call declaration #1329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for parsing defcall declarations, along with an appropriate AST node.
This adds support for the resolution, processing and typing stages for the DefCall construct. An initial implementation of translation is also included, but this does not yet actually translate the call.
This adds support for checking arguments and returns. In particular, check that there are enough arguments and returns, and also that their bitwidths follow the expected subtyping pattern.
This adds support for encoding and decoding of function calls, and also adds a number of tests.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| fmt.Sprintf("insufficient arguments for function \"%s\"", decl.Function))) | ||
| } else if i >= nArgs && !ith.IsOutput() { | ||
| return append(errors, *t.srcmap.SyntaxError(decl.Returns[i-nArgs], | ||
| fmt.Sprintf("too many arguments for function \"%s\"", decl.Function))) |
There was a problem hiding this comment.
Bug: Error Message Confuses Returns with Arguments
The error message in checkArgsReturns is incorrect when checking returns. At line 355, when a return register is not marked as output (i >= nArgs && !ith.IsOutput()), the error message says "too many arguments" but should indicate a problem with returns or output registers. The message does not match the actual condition being validated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Add function call (
defcall) support end-to-end with sample zkASM funcs and comprehensive unit/invalid tests.defcall) acrosscorset(AST, parser, resolver, typing, translator, intrinsics, preprocessor) and IR (HIR, lowering, term/constraint handling).id,add u32,dec u16) with modulo arithmetic and preconditions.fncall_01..03) with accepted/expanded outputs and edge cases.corsetfunction call cases and update mixed large fixture.Written by Cursor Bugbot for commit f644066. This will update automatically on new commits. Configure here.