fix: error for lookups with same handle #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two (failing) tests for this issue.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
| // | ||
| handle := elements[1].AsSymbol().Value | ||
| qualifiedHandle := fmt.Sprintf("%s:%s", module.String(), handle) |
There was a problem hiding this comment.
Bug: Nil Pointer Panic in Definition Parsing
Potential nil pointer dereference in parseDefSorted. When isIdentifier(elements[1]) returns false, an error is appended but execution continues to line 1185 where elements[1].AsSymbol().Value is called. Since isIdentifier returns false when AsSymbol() returns nil, this will panic. The handle extraction should be inside an else block like in parseDefProperty, or the function should return early like in parseDefConstraint.
Previously, the algorithm for checking that two constraints do not have the same handle (in the same module) only worked when the constraints were defined within the same module block. However, if they were defined in different blocks (e.g. in different files) the duplicate handle was not reported as an error. To resolve this, a global map of all handles is now maintained which is shared across all source files and module blocks.
DavePearce
force-pushed
the
1279-fix-error-for-lookups-with-same-handle
branch
from
71ead2d to
eaa5f22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Tracks module-qualified handles to error on duplicates across files/fragments for constraints, lookups, properties, and sorted declarations; adds failing tests.
Parser.handles) shared across files viaParseSourceFiles→parseSourceFile→NewParser(..., handles).defconstraint,deflookup,defclookup,defmlookup,defproperty,defsorted/defstrictsortedusing qualified names (module:handle).moduleand remove per-callhandlesmaps (e.g.,parseDefConstraint,parseDefLookup,parseDefConditionalLookup,parseDefMultiLookup,parseDefProperty,parseDefSorted,parseLookupHandle).basic_invalid_20.lispandlookup_invalid_19.lispasserting "duplicate handle" across repeatedmodule m1fragments.pkg/test/corset_invalid_test.go.Written by Cursor Bugbot for commit eaa5f22. This will update automatically on new commits. Configure here.