Handle omitted/unused optional parameters in a JSON-RPC request#314
Merged
msgilligan merged 1 commit intoConsensusJ:masterfrom Feb 24, 2026
Merged
Conversation
msgilligan
requested changes
Feb 10, 2026
Member
msgilligan
left a comment
msgilligan
left a comment
There was a problem hiding this comment.
Looks good, but I have three minor requests.
...ensusj-jsonrpc/src/main/java/org/consensusj/jsonrpc/introspection/JsonRpcServiceWrapper.java
Outdated
Show resolved
Hide resolved
...ensusj-jsonrpc/src/main/java/org/consensusj/jsonrpc/introspection/JsonRpcServiceWrapper.java
Outdated
Show resolved
Hide resolved
...ensusj-jsonrpc/src/main/java/org/consensusj/jsonrpc/introspection/JsonRpcServiceWrapper.java
Outdated
Show resolved
Hide resolved
JSON-RPC allows for unused optional parameters to be omitted from the `params` member of a Request object when `params` is represented by an Array. It only requires that required parameters are present and that the present parameters are in the order the server expects. For more details, see https://www.jsonrpc.org/specification\#parameter_structures
liamgilligan
force-pushed
the
jrpc-param-handling
branch
from
20b71d9 to
c456844
Compare
msgilligan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON-RPC allows for unused optional parameters to be omitted from the
paramsmember of a Request object.paramsis represented by an Array. It only requires that required parameters are present and that the present parameters are in the order the server expects. For more details, see https://www.jsonrpc.org/specification#parameter_structuresThis PR adds the server-side functionality to handle these omitted parameters when they are given by-position, as specified in the JSON-RPC spec.