Skip to content

Add progress bar to all permutation tests#12

Merged
ConnorStoneAstro merged 2 commits intoConnorStoneAstro:mainfrom
fangyizhu:main
Jan 29, 2026
Merged

Add progress bar to all permutation tests#12
ConnorStoneAstro merged 2 commits intoConnorStoneAstro:mainfrom
fangyizhu:main

Conversation

@fangyizhu
Copy link
Contributor

I realized progress bars can get overwhelming if pted is put in any kind of loop run, so I keep the default to be False.

Fixes #11

I realized progress bars can get overwhelming if pted is put in any kind of loop run, so I keep the default to be False.
Copy link
Owner

@ConnorStoneAstro ConnorStoneAstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! And great job with the unit test! I just have one tweak from here, listed below.

@ConnorStoneAstro
Copy link
Owner

Oh, also it looks like you need to add tqdm to the requirements.txt file.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.47%. Comparing base (6ec49f6) to head (ae44e8d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   98.46%   98.47%   +0.01%     
==========================================
  Files           4        4              
  Lines         260      262       +2     
==========================================
+ Hits          256      258       +2     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@ConnorStoneAstro ConnorStoneAstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, thanks for contributing!

@ConnorStoneAstro ConnorStoneAstro merged commit a5a45a8 into ConnorStoneAstro:main Jan 29, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Show progress bar

3 participants