Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1521 1521
=========================================
Hits 1521 1521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mjyb16
approved these changes
Feb 10, 2026
mjyb16
left a comment
There was a problem hiding this comment.
Looking good! Just a couple small things to clarify: does shape = None just assume no shape at all, and does shape = (None, ) assume a 1D shape?
Owner
Author
That's right! Good point though, I'll make that clear in the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Param shape can now have
Noneas an entry. It will take the size of that dimension from the param value if available. This allows specifying the structure of a param without specifying the exact shape. Such as requiring an entry to be an image (2D with shape(None, None)) of any size.