fix(client): replace TaskTurnPedToFaceCoord with SetEntityHeading to prevent canceled animations

[0Programmer]

This fix ensures that TaskTurnPedToFaceCoord is only run once, preserving ongoing or new animations.

Is it necessary to run this every few ticks? If so, I can adjust it.

[Maximus7474]

What use case does this satisfy ?
The main idea for having it run in the interval is to guarantee the player is always facing the other when searching him. This is purely an aesthetical feature because the other player can move around while being searched while still being in range.

[0Programmer]

TaskTurnPedToFaceCoord cancels any animation started while the player is being searched. So if you want to play new animations during the search, they won’t work properly.

Possible ways around this:

• Run it once to line up the ped, and only run it again if the heading is way off.
• Add a convar for people who don’t really need the constant facing and want to handle it themselves.
• Swap out TaskTurnPedToFaceCoord for GetHeadingFromVector_2d + SetEntityHeading using ped/target coords.

    local heading = GetHeadingFromVector_2d(
        pedCoords.x - playerCoords.x,
        pedCoords.y - playerCoords.y
    )
    SetEntityHeading(playerPed, heading)

I guess only a small group actually wants animations while searching/robbing, so maybe we just close the PR and let them tweak it themselves. Still, could be nice to mention in Common Issues, since it took me a while to figure out why animations kept getting canceled.

[Maximus7474]

I'd say set heading is more appropriate solution to the issue described that wouldn't effect current servers.

[0Programmer]

I thought the same, I’ve already pushed that change.

[FjamZoo]

IMO, changing it from something that actively moves your ped in the right direction to instant setting your direction is the wrong approach.

[0Programmer]

I guess, but for now this solves the issue described (TaskTurnPedToFaceCoord cancels animations), might be the only one that wants animations while inside others inventory. I do not have that much time to find a better solution, feel free to edit, close this pr and reapply a better solution.