Skip to content

Complete missing paragraphs in welcome.md, Fix broken accessibility settings link in setup-guide.md, Correct NVDA modifier key in keyboard-shortcuts.md#2318

Open
sam-cal1 wants to merge 5 commits intomainfrom
fix-sam-cal1-issue2317
Open

Complete missing paragraphs in welcome.md, Fix broken accessibility settings link in setup-guide.md, Correct NVDA modifier key in keyboard-shortcuts.md#2318
sam-cal1 wants to merge 5 commits intomainfrom
fix-sam-cal1-issue2317

Conversation

@sam-cal1
Copy link
Copy Markdown
Collaborator

What does this PR do?

  • In welcome.md, added the paragraphs that were required.
  • In setup guide.md, fix a broken link, and added a required missing one.
  • In keyboard shortcuts.md, added the missing NVDA command to read current line in laptop layout.

Which issue does this close?

Closes #2317

What type of change is this?

  • Fix a bug or error in an existing file
  • Add new content or a missing section
  • Improve accessibility (headings, links, alt text)
  • Improve clarity or rewrite confusing content
  • Other (describe below)

Checklist

  • I tested my changes with a screen reader or checked heading structure
  • All links point to real files that exist in this repo
  • All images have descriptive alt text
  • No [TODO] markers remain in my changes
  • My commit message describes what changed and why

How to review this PR

  1. Read the changed file(s) in the Files Changed tab
  2. Check that headings follow proper hierarchy (H1, H2, H3 - no skips)
  3. Verify links work by clicking them
  4. Read link text out of context - does it still make sense?

Anything else?

add the missing NVDA command to read line in laptop layout
fix a broken link, and add a missing one in TODO.
@github-actions
Copy link
Copy Markdown

Challenge 10: Local commit verified!

Found 4 commit(s) on branch fix-sam-cal1-issue2317.
Your local Git workflow is working. Well done!

@github-actions
Copy link
Copy Markdown

Challenge 7: Conflict markers still present

Your PR still contains Git conflict markers (<<<<<<<, =======, >>>>>>>).
These need to be removed as part of resolving the merge conflict.

What to do: Open the file, find the conflict markers, decide which lines to keep,
and delete the marker lines. Then commit and push again.

See Chapter 7: Merge Conflicts for help.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

📋 Content Validation Report

♿ Accessibility

  • Table Description (docs/keyboard-shortcuts.md Line 16)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 17)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 18)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 19)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 20)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 21)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 22)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 23)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 24)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 25)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 26)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 27)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 31)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 32)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 33)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 34)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 38)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 39)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 40)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 42)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 52)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 53)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 54)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 55)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 56)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 57)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 58)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 59)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 60)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 61)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 62)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 66)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 67)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 68)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 69)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 70)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 74)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 75)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 76)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 77)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 78)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 96)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 97)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 98)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 99)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 100)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 101)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 102)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 103)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 104)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 105)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 115)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 116)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 117)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 118)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 119)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 120)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 124)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 125)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 126)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 127)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 128)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 129)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 130)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

  • Table Description (docs/keyboard-shortcuts.md Line 131)
    Consider adding a brief description before tables explaining their content.
    Fix: Add one sentence before the table explaining what data it contains.

📚 Learning Resources


Automated validation by Learning Room. Questions? Check the guides or mention @Facilitator.

@github-actions
Copy link
Copy Markdown

Hi! I'm Aria. Here is my review of your pull request:

Report Status

🎉 Hooray! Validation Passed

➡️ Great job! You unlocked the next level.
Head back to the Course Guide to see what chapter is next!

Required Checks

  • Issue Reference

  • PR Description

Learning Resources

Based on your changes, these guides might help:


Automated validation by Aria, your Workshop Agent. Last updated: 2026-03-30T15:48:40.434Z
Questions? Check PR Guidelines or mention @Facilitator

@github-actions
Copy link
Copy Markdown

Challenge 7: Conflict markers still present

Your PR still contains Git conflict markers (<<<<<<<, =======, >>>>>>>).
These need to be removed as part of resolving the merge conflict.

What to do: Open the file, find the conflict markers, decide which lines to keep,
and delete the marker lines. Then commit and push again.

See Chapter 7: Merge Conflicts for help.

@github-actions
Copy link
Copy Markdown

Challenge 10: Local commit verified!

Found 5 commit(s) on branch fix-sam-cal1-issue2317.
Your local Git workflow is working. Well done!

@github-actions
Copy link
Copy Markdown

Hi! I'm Aria. Here is my review of your pull request:

Report Status

🎉 Hooray! Validation Passed

➡️ Great job! You unlocked the next level.
Head back to the Course Guide to see what chapter is next!

Required Checks

  • Issue Reference

  • PR Description

Learning Resources

Based on your changes, these guides might help:


Automated validation by Aria, your Workshop Agent. Last updated: 2026-03-31T05:17:34.176Z
Questions? Check PR Guidelines or mention @Facilitator

Removed conflict markers and updated instructions for opening settings.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Challenge 7: Conflict markers still present

Your PR still contains Git conflict markers (<<<<<<<, =======, >>>>>>>).
These need to be removed as part of resolving the merge conflict.

What to do: Open the file, find the conflict markers, decide which lines to keep,
and delete the marker lines. Then commit and push again.

See Chapter 7: Merge Conflicts for help.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Challenge 10: Local commit verified!

Found 6 commit(s) on branch fix-sam-cal1-issue2317.
Your local Git workflow is working. Well done!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Hi! I'm Aria. Here is my review of your pull request:

Report Status

🎉 Hooray! Validation Passed

➡️ Great job! You unlocked the next level.
Head back to the Course Guide to see what chapter is next!

Required Checks

  • Issue Reference

  • PR Description

Learning Resources

Based on your changes, these guides might help:


Automated validation by Aria, your Workshop Agent. Last updated: 2026-04-03T04:55:30.026Z
Questions? Check PR Guidelines or mention @Facilitator

@sam-cal1 sam-cal1 requested a review from accesswatch April 4, 2026 03:05
@sam-cal1 sam-cal1 added the challenge: beginner Beginner-level challenge label Apr 4, 2026
@sam-cal1 sam-cal1 self-assigned this Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

challenge: beginner Beginner-level challenge

Projects

None yet

1 participant