-
Notifications
You must be signed in to change notification settings - Fork 28
C;CLCC: TitleMenu and SystemMenu Fog Effect #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,20 @@ void Configure() { | |
| ItemsFadeInDuration = EnsureGetMember<float>("ItemsFadeInDuration"); | ||
| ItemsFadeOutDuration = EnsureGetMember<float>("ItemsFadeOutDuration"); | ||
|
|
||
| SmokeOpacityNormal = EnsureGetMember<float>("SmokeOpacityNormal"); | ||
| SmokeX = EnsureGetMember<float>("SmokeX"); | ||
| SmokeY = EnsureGetMember<float>("SmokeY"); | ||
| SmokeBoundsX = EnsureGetMember<float>("SmokeBoundsX"); | ||
| SmokeBoundsY = EnsureGetMember<float>("SmokeBoundsY"); | ||
| SmokeBoundsWidth = EnsureGetMember<float>("SmokeBoundsWidth"); | ||
| SmokeBoundsHeight = EnsureGetMember<float>("SmokeBoundsHeight"); | ||
| SmokeAnimationBoundsXOffset = | ||
| EnsureGetMember<float>("SmokeAnimationBoundsXOffset"); | ||
| SmokeAnimationBoundsXMax = EnsureGetMember<float>("SmokeAnimationBoundsXMax"); | ||
| SmokeAnimationDurationIn = EnsureGetMember<float>("SmokeAnimationDurationIn"); | ||
| SmokeAnimationDurationOut = | ||
| EnsureGetMember<float>("SmokeAnimationDurationOut"); | ||
|
|
||
| GetMemberArray<glm::vec2>( | ||
| std::span(MenuEntriesPositions, Profile::SystemMenu::MenuEntriesNum), | ||
| "MenuEntriesPositions"); | ||
|
|
@@ -29,6 +43,7 @@ void Configure() { | |
| SystemMenuFrame = EnsureGetMember<Sprite>("SystemMenuFrame"); | ||
| MenuButtonGuide = EnsureGetMember<Sprite>("MenuButtonGuide"); | ||
| SystemMenuMask = EnsureGetMember<Sprite>("SystemMenuMask"); | ||
| SmokeSprite = EnsureGetMember<Sprite>("SmokeSprite"); | ||
|
|
||
| BGDispOffsetTopLeft = EnsureGetMember<glm::vec2>("BGDispOffsetTopLeft"); | ||
| BGDispOffsetBottomLeft = EnsureGetMember<glm::vec2>("BGDispOffsetBottomLeft"); | ||
|
|
@@ -45,6 +60,12 @@ void Configure() { | |
|
|
||
| BGTranslationOffset = EnsureGetMember<glm::vec2>("BGTranslationOffset"); | ||
|
|
||
| UI::CCLCC::SystemMenu* menu = new UI::CCLCC::SystemMenu(); | ||
|
|
||
| menu->SmokeAnimation.LoopMode = AnimationLoopMode::Loop; | ||
| menu->SmokeAnimation.DurationIn = SmokeAnimationDurationIn; | ||
| menu->SmokeAnimation.DurationOut = SmokeAnimationDurationOut; | ||
|
Comment on lines
+63
to
+67
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The menu pointer is already created and pushed a couple lines below? The durations are also already set in the constructor |
||
|
|
||
| auto drawType = Game::DrawComponentType::_from_integral_unchecked( | ||
| EnsureGetMember<uint8_t>("DrawType")); | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,13 +14,26 @@ inline Sprite SystemMenuBG; | |
| inline Sprite MenuButtonGuide; | ||
| inline Sprite SystemMenuFrame; | ||
| inline Sprite SystemMenuMask; | ||
| inline Sprite SmokeSprite; | ||
| inline float MoveInDuration; | ||
| inline float MoveOutDuration; | ||
| inline float ItemsFadeInDuration; | ||
| inline float ItemsFadeOutDuration; | ||
| inline glm::vec2 MenuEntriesPositions[MenuEntriesNumMax]; | ||
| inline RectF MenuEntriesButtonBounds[MenuEntriesNumMax]; | ||
|
|
||
| inline float SmokeOpacityNormal; | ||
| inline float SmokeX; | ||
| inline float SmokeY; | ||
| inline float SmokeBoundsX; | ||
| inline float SmokeBoundsY; | ||
| inline float SmokeBoundsWidth; | ||
| inline float SmokeBoundsHeight; | ||
|
Comment on lines
+26
to
+31
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just use a |
||
| inline float SmokeAnimationBoundsXOffset; | ||
| inline float SmokeAnimationBoundsXMax; | ||
| inline float SmokeAnimationDurationIn; | ||
| inline float SmokeAnimationDurationOut; | ||
|
|
||
| inline glm::vec2 BGDispOffsetTopLeft; | ||
| inline glm::vec2 BGDispOffsetBottomLeft; | ||
| inline glm::vec2 BGDispOffsetTopRight; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like the idea of modifying this profile variable's bounds...
I'd make a local copy of the sprite and modify that instead