Skip to content

fix: fail CLA allowlist step on API errors - #64

Merged
alexisrolland merged 1 commit into
mainfrom
fix/cla-api-failure-handling
Aug 21, 2026
Merged

fix: fail CLA allowlist step on API errors#64
alexisrolland merged 1 commit into
mainfrom
fix/cla-api-failure-handling

Conversation

@alexisrolland

Copy link
Copy Markdown
Member

Summary

Make the CLA author allowlist step fail when its GitHub API request fails instead of silently continuing with only the base allowlist.

Changes

  • Capture the pull request commit API response before filtering authors.
  • Fail explicitly when the API request or pagination fails.
  • Preserve the valid author-only case where filtering produces no co-authors.

Verification

The shared implementation was validated for author-only, co-author, and simulated API-failure scenarios in Comfy-Org/comfy-cla.

Propagates Comfy-Org/comfy-cla#1 and addresses Comfy-Org/ComfyUI_frontend#15555.

@alexisrolland
alexisrolland requested review from a team as code owners August 21, 2026 18:58
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5720995a-4e82-46d3-b3bf-f8e8906e1e44


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alexisrolland
alexisrolland merged commit 2c1bded into main Aug 21, 2026
11 checks passed
@alexisrolland
alexisrolland deleted the fix/cla-api-failure-handling branch August 21, 2026 19:27
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants