Test register families with fixed-seed properties - #129
Merged
Conversation
|
Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 99 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds reproducible fast-check properties for node presence/incarnation, widget, concrete input, promoted input, and inputcount registers. Each family runs 240 fixed-seed scenarios covering version, actor, and op_id tiebreaks; winner and loser retries; three batch/interleaving shapes; and both arrival orders. Post-run vacuity guards require every dimension to have nonzero sampled coverage.
This holds KA-2 embedded total ordering, KA-4 convergence/idempotency, and KA-10 single-snapshot forks. The inputcount assertion is deliberately register-scoped: it sorts source output link references before cross-order comparison because those references remain arrival-ordered outside this PR's register-family scope.
Verification: