Skip to content

Test register families with fixed-seed properties - #129

Merged
christian-byrne merged 1 commit into
mainfrom
test/perm3-register-properties
Aug 30, 2026
Merged

Test register families with fixed-seed properties#129
christian-byrne merged 1 commit into
mainfrom
test/perm3-register-properties

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Adds reproducible fast-check properties for node presence/incarnation, widget, concrete input, promoted input, and inputcount registers. Each family runs 240 fixed-seed scenarios covering version, actor, and op_id tiebreaks; winner and loser retries; three batch/interleaving shapes; and both arrival orders. Post-run vacuity guards require every dimension to have nonzero sampled coverage.

This holds KA-2 embedded total ordering, KA-4 convergence/idempotency, and KA-10 single-snapshot forks. The inputcount assertion is deliberately register-scoped: it sorts source output link references before cross-order comparison because those references remain arrival-ordered outside this PR's register-family scope.

Verification:

  • Node 25.9: build, purity, pins, profile claims, CodeRabbit generation, statelessness, corpus, typecheck, and focused property suite pass; full Vitest is 819/827 with the eight known dependency-cruiser Node 25 incompatibility failures.
  • Node 24.20: import graph passes (17 modules / 46 dependencies) and full Vitest passes 827/827.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 56 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 99 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 250040eb-026c-4987-aa7a-89f82b1654ad

📥 Commits

Reviewing files that changed from the base of the PR and between bfd7bf4 and e45b57a.

📒 Files selected for processing (1)
  • test/register-families.property.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Aug 30, 2026
@christian-byrne
christian-byrne merged commit 5f880f6 into main Aug 30, 2026
7 checks passed
@christian-byrne
christian-byrne deleted the test/perm3-register-properties branch August 30, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R1 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant