Add preview to workflow tabs #4290
Conversation
|
Claude Code review I reviewed this thoroughly and found that most potential concerns are already properly handled: Memory management with blob URLs - The code correctly calls Manual DOM positioning - The manual positioning addresses a PrimeVue bug with scrolled tabs, as noted in the code comments. The workaround is reasonable. Removed tooltip - The v-tooltip removal is intentional, replaced by a richer popover with visual preview that mirrors browser tab behavior. Device pixel ratio - While DPR support could make thumbnails crisper on high-DPI displays, the current implementation works well with browser image scaling. CSS variables with Tailwind - Using CSS variables for dynamic popover width that's referenced in multiple places is a practical pattern here. The implementation is solid with good test coverage and follows Vue 3 best practices. |
| const handleMouseLeave = () => { | ||
| popoverRef.value?.hidePopover() | ||
| } |
There was a problem hiding this comment.
Should we also call hidePopover during unmount?
| sourceHeight = graphCanvas.width / targetAspect | ||
| sourceY = (graphCanvas.height - sourceHeight) / 2 | ||
| } | ||
|
|
There was a problem hiding this comment.
I wonder if there's a good way to get the low quality / zoomed-out render of litegraph before drawing.
Adds a preview of the graph when you hover over the tab
┆Issue is synchronized with this Notion page by Unito