Skip to content

Update eslint dependencies #3877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2025
Merged

Update eslint dependencies #3877

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d3c84d
Sort rules
amanmahajan7 Sep 29, 2025
b952587
Migrate to `@eslint-react/eslint-plugin`
amanmahajan7 Sep 29, 2025
64f8a6e
Use prettier to format everything
amanmahajan7 Sep 29, 2025
570daa4
Disable formatting
amanmahajan7 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 28 additions & 16 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
{
"$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
"assist": { "actions": { "source": { "organizeImports": "off" } } },
"css": {
"formatter": {
"quoteStyle": "single"
}
},
"files": {
"includes": [
"**",
Expand All @@ -20,29 +26,23 @@
"indentStyle": "space",
"lineWidth": 100
},
"json": {
"parser": {
"allowComments": true,
"allowTrailingCommas": true
}
},
"javascript": {
"formatter": {
"quoteStyle": "single",
"trailingCommas": "none"
}
},
"css": {
"formatter": {
"quoteStyle": "single"
"json": {
"parser": {
"allowComments": true,
"allowTrailingCommas": true
}
},
"linter": {
"domains": {
"project": "recommended"
},
"rules": {
"recommended": false,
"a11y": {
"noAccessKey": "warn",
"noAriaHiddenOnFocusable": "warn",
Expand Down Expand Up @@ -193,8 +193,8 @@
"useSingleJsDocAsterisk": "warn",
"useUniqueElementIds": "off",
"useValidForDirection": "warn",
"useYield": "warn",
"useValidTypeof": "warn"
"useValidTypeof": "warn",
"useYield": "warn"
},
"performance": {
"noAccumulatingSpread": "warn",
Expand All @@ -206,6 +206,7 @@
"noReExportAll": "off",
"useTopLevelRegex": "warn"
},
"recommended": false,
"security": {
"noBlankTarget": "warn",
"noDangerouslySetInnerHtml": "warn",
Expand All @@ -215,15 +216,16 @@
"style": {
"noDefaultExport": "off",
"noDoneCallback": "warn",
"noExportedImports": "off",
"noEnum": "off",
"noExportedImports": "off",
"noImplicitBoolean": "off",
"noInferrableTypes": "warn",
"noNamespace": "warn",
"noNegationElse": "warn",
"noNonNullAssertion": "off",
"noParameterAssign": "off",
"noParameterProperties": "warn",
"noRestrictedGlobals": "warn",
"noRestrictedImports": {
"level": "warn",
"options": {
Expand All @@ -239,7 +241,6 @@
}
}
},
"noRestrictedGlobals": "warn",
"noShoutyConstants": "warn",
"noSubstr": "off",
"noUnusedTemplateLiteral": "warn",
Expand All @@ -250,8 +251,8 @@
"useAtIndex": "off",
"useBlockStatements": "off",
"useCollapsedElseIf": "warn",
"useComponentExportOnlyModules": "off",
"useCollapsedIf": "warn",
"useComponentExportOnlyModules": "off",
"useConsistentArrayType": "warn",
"useConsistentBuiltinInstantiation": "warn",
"useConsistentObjectDefinitions": "warn",
Expand Down Expand Up @@ -361,7 +362,6 @@
}
}
},
"assist": { "actions": { "source": { "organizeImports": "off" } } },
"overrides": [
{
"includes": ["**/*.test.*"],
Expand All @@ -385,6 +385,18 @@
}
}
}
},
{
"assist": { "actions": { "source": { "organizeImports": "on" } } },
"includes": ["**/*.js"]
Copy link
Collaborator Author

@amanmahajan7 amanmahajan7 Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not have this turned on for *.js files? Also, should we remove https://github.com/Comcast/react-data-grid/blob/main/.prettierignore#L1-L3 and let prettier handle everything. Wdyt?

},
{
"assist": {
"actions": {
"source": { "useSortedKeys": "on" }
}
},
"includes": ["./biome.json"]
}
]
}
19 changes: 12 additions & 7 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import markdown from '@eslint/markdown';
import reactX from '@eslint-react/eslint-plugin';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://eslint-react.xyz/docs/changelog#v200-2025-09-26

import typescriptEslint from '@typescript-eslint/eslint-plugin';
import tsParser from '@typescript-eslint/parser';
import vitest from '@vitest/eslint-plugin';
Expand All @@ -6,10 +8,8 @@ import jestDom from 'eslint-plugin-jest-dom';
import react from 'eslint-plugin-react';
import reactCompiler from 'eslint-plugin-react-compiler';
import reactHooks from 'eslint-plugin-react-hooks';
import reactHooksExtra from 'eslint-plugin-react-hooks-extra';
import sonarjs from 'eslint-plugin-sonarjs';
import testingLibrary from 'eslint-plugin-testing-library';
import markdown from '@eslint/markdown';

export default defineConfig([
globalIgnores(['.cache', '.nitro', '.output', '.tanstack', 'coverage', 'dist', 'lib']),
Expand All @@ -28,7 +28,7 @@ export default defineConfig([
react,
'react-compiler': reactCompiler,
'react-hooks': reactHooks,
'react-hooks-extra': reactHooksExtra,
'react-x': reactX,
sonarjs,
'@typescript-eslint': typescriptEslint
},
Expand Down Expand Up @@ -249,6 +249,7 @@ export default defineConfig([
'prefer-rest-params': 1,
'prefer-spread': 1,
'prefer-template': 1,
'preserve-caught-error': 1,
radix: 1,
'require-await': 0, // replaced by @typescript-eslint/require-await
'require-unicode-regexp': 0,
Expand Down Expand Up @@ -393,10 +394,10 @@ export default defineConfig([

// React Hooks Extra
// https://eslint-react.xyz/
'react-hooks-extra/no-unnecessary-use-callback': 1,
'react-hooks-extra/no-unnecessary-use-memo': 1,
'react-hooks-extra/no-unnecessary-use-prefix': 1,
'react-hooks-extra/prefer-use-state-lazy-initialization': 1,
'react-x/no-unnecessary-use-callback': 1,
'react-x/no-unnecessary-use-memo': 1,
'react-x/no-unnecessary-use-prefix': 1,
'react-x/prefer-use-state-lazy-initialization': 1,

// SonarJS rules
// https://github.com/SonarSource/eslint-plugin-sonarjs#rules
Expand Down Expand Up @@ -606,6 +607,7 @@ export default defineConfig([
'vitest/consistent-test-filename': 0,
'vitest/consistent-test-it': 1,
'vitest/expect-expect': 0,
'vitest/hoisted-apis-on-top': 1,
'vitest/max-expects': 0,
'vitest/max-nested-describe': 0,
'vitest/no-alias-methods': 1,
Expand Down Expand Up @@ -755,7 +757,10 @@ export default defineConfig([
'markdown/no-missing-atx-heading-space': 1,
'markdown/no-missing-label-refs': 1,
'markdown/no-missing-link-fragments': 1,
'markdown/no-multiple-h1': 1,
'markdown/no-reference-like-urls': 1,
'markdown/no-reversed-media-syntax': 1,
'markdown/no-space-in-emphasis': 1,
'markdown/no-unused-definitions': 1,
'markdown/require-alt-text': 1,
'markdown/table-column-count': 1
Expand Down
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@
"devDependencies": {
"@babel/preset-typescript": "^7.27.1",
"@biomejs/biome": "2.2.4",
"@eslint/markdown": "^7.1.0",
"@eslint-react/eslint-plugin": "^2.0.2",
"@eslint/markdown": "^7.3.0",
"@faker-js/faker": "^10.0.0",
"@ianvs/prettier-plugin-sort-imports": "^4.6.2",
"@linaria/core": "^6.3.0",
Expand All @@ -71,14 +72,13 @@
"@vitest/eslint-plugin": "^1.3.4",
"@wyw-in-js/rollup": "^0.7.0",
"@wyw-in-js/vite": "^0.7.0",
"eslint": "^9.34.0",
"eslint": "^9.36.0",
"eslint-plugin-jest-dom": "^5.5.0",
"eslint-plugin-react": "^7.37.4",
"eslint-plugin-react": "^7.37.5",
"eslint-plugin-react-compiler": "^19.1.0-rc.2",
"eslint-plugin-react-hooks": "^5.2.0",
"eslint-plugin-react-hooks-extra": "^1.52.6",
"eslint-plugin-sonarjs": "^3.0.5",
"eslint-plugin-testing-library": "^7.6.6",
"eslint-plugin-testing-library": "^7.10.0",
"jspdf": "^3.0.1",
"jspdf-autotable": "^5.0.2",
"playwright": "^1.54.2",
Expand Down