Move navbar out of flex container to fix iOS rendering#6
Open
as2340 wants to merge 1 commit intoColt:masterfrom
Open
Move navbar out of flex container to fix iOS rendering#6as2340 wants to merge 1 commit intoColt:masterfrom
as2340 wants to merge 1 commit intoColt:masterfrom
Conversation
The navbar does not render correctly on iOS - it does not force content below down when expanded. Having tried everything else with no improvement, creating an extra div inside the body so the navbar can sit outside the flexbox container appears to have fixed the issue with no unintended consequences I have found so far!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navbar does not render correctly on iOS - it does not force content below down when expanded. Having tried everything else with no improvement, creating an extra div inside the body so the navbar can sit outside the flexbox container appears to have fixed the issue with no unintended consequences I have found so far!
By the way, I have just finished WDB which was awesome - took over my life for a couple of weeks! I'm a Github rookie too so apologies if I'm going about anything the wrong way. My first big problem post-deployment of my YelpCamp was the security policy not allowing the maps to render on iOS. I found the fix by seeing somebody had proposed a change on here so thought I'd try and use this as a mechanism to share my navbar woes with the community - it's a surprisingly not well-documented matter on the likes of stack-exchange...