delete cloudindary images for delete route#10
Open
Nspired1 wants to merge 1 commit intoColt:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some code that will delete images in cloudinary from the delete route. Technically, the code is in the campground controller, but it's the deleteCampground route that will initiate the action. Makes delete the same as the editCampground controller.
Minor inconvenience of having the cloudinary account get filled, though the campgrounds were deleted. Thinking about making the code shorter, but a friend at Salesforce said his department policy is "NO one line functions." Not even their smartest engineers remember what they did six months later. Better to write it out and make it easy to understand.