Skip to content

[WIP] Add new feature to improve user experience#4

Draft
Copilot wants to merge 1 commit intomainfrom
copilot/add-new-feature
Draft

[WIP] Add new feature to improve user experience#4
Copilot wants to merge 1 commit intomainfrom
copilot/add-new-feature

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 5, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI requested a review from Coff0xc February 5, 2026 07:13
Copilot stopped work on behalf of Coff0xc due to an error February 5, 2026 07:13
Coff0xc added a commit that referenced this pull request Apr 8, 2026
- core/sandbox/fallback.py: Eliminate shell injection in run_python()
  and run_tool() — use subprocess list args instead of shell=True
  (Finding #2/#3/#4/#5)
- core/knowledge/storage.py: Add check_same_thread=False for MCP
  multi-threaded context (Finding #6)
- core/sandbox/config.py: Remove unused `import time` (Finding #1)

Remaining lower-priority items noted for future iteration:
- #7: Batch commit for bulk entity loading
- #8: BFS N+1 → recursive CTE
- #9/#10: Dual-write consistency (architectural)
- #11/#12: Shared HTTPClient for Nuclei engine
- #13: Unbounded glob cap
- #14: Regex ReDoS guard
Coff0xc added a commit that referenced this pull request Apr 9, 2026
LLM security (#4/#5/#11):
- ai_engine: add Pydantic schema (LLMAttackSuggestion, LLMAnalysisResponse)
  for LLM output validation, preventing prompt injection attacks
- llm/provider: integrate schema validation in provider response parsing

Security defaults (#10/#12):
- config/models: expand blocked_targets to RFC 1918, cloud metadata, IPv6
  loopback; add LEGAL_DISCLAIMER constant for startup warning

Operation audit (#20):
- utils/mcp_tooling: add _write_audit_record() — every tool call logged to
  data/operation_audit.jsonl (tool_name, params_hash, result, timing)

Input validation (#8/#9):
- ad_handlers: add @validate_inputs(target="dc_ip") to 3 AD tools
- mcts_handlers: add @validate_inputs(target="target") to plan_attack_path
- parallel_handlers: add @validate_inputs(target="urls") to parallel_scan

CI improvements (#7/#21/#23):
- pyproject.toml: raise pylint fail-under from 8 to 50
- ci.yml: add pip-audit security scan step; raise --cov-fail-under to 50
- tests/test_cli.py: new CLI test file (11 tests, 3 classes)

Payload optimization (#1/#16):
- core/payload/loader: PayloadDB lazy-loading singleton with _ensure_loaded()
  and thread-safe double-checked locking; per-category access
@Coff0xc Coff0xc force-pushed the copilot/add-new-feature branch from 4b70200 to f3a414c Compare April 21, 2026 10:00
Coff0xc added a commit that referenced this pull request Apr 21, 2026
- core/sandbox/fallback.py: Eliminate shell injection in run_python()
  and run_tool() — use subprocess list args instead of shell=True
  (Finding #2/#3/#4/#5)
- core/knowledge/storage.py: Add check_same_thread=False for MCP
  multi-threaded context (Finding #6)
- core/sandbox/config.py: Remove unused `import time` (Finding #1)

Remaining lower-priority items noted for future iteration:
- #7: Batch commit for bulk entity loading
- #8: BFS N+1 → recursive CTE
- #9/#10: Dual-write consistency (architectural)
- #11/#12: Shared HTTPClient for Nuclei engine
- #13: Unbounded glob cap
- #14: Regex ReDoS guard
Coff0xc added a commit that referenced this pull request Apr 21, 2026
LLM security (#4/#5/#11):
- ai_engine: add Pydantic schema (LLMAttackSuggestion, LLMAnalysisResponse)
  for LLM output validation, preventing prompt injection attacks
- llm/provider: integrate schema validation in provider response parsing

Security defaults (#10/#12):
- config/models: expand blocked_targets to RFC 1918, cloud metadata, IPv6
  loopback; add LEGAL_DISCLAIMER constant for startup warning

Operation audit (#20):
- utils/mcp_tooling: add _write_audit_record() — every tool call logged to
  data/operation_audit.jsonl (tool_name, params_hash, result, timing)

Input validation (#8/#9):
- ad_handlers: add @validate_inputs(target="dc_ip") to 3 AD tools
- mcts_handlers: add @validate_inputs(target="target") to plan_attack_path
- parallel_handlers: add @validate_inputs(target="urls") to parallel_scan

CI improvements (#7/#21/#23):
- pyproject.toml: raise pylint fail-under from 8 to 50
- ci.yml: add pip-audit security scan step; raise --cov-fail-under to 50
- tests/test_cli.py: new CLI test file (11 tests, 3 classes)

Payload optimization (#1/#16):
- core/payload/loader: PayloadDB lazy-loading singleton with _ensure_loaded()
  and thread-safe double-checked locking; per-category access
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants