Skip to content

chore(List): swap List to container queries #3133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Jul 14, 2025

Overview

Swaps List, DataGrid + DataTable over to container query. Also adds wrapperWidth prop for when folks need direct access to the table element

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [gm-1231]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Go to DataTable + List story
  2. See they now become cards at a container size
  3. Head to DataList and see the table at a breakpoint view but with a static width

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

Copy link

nx-cloud bot commented Jul 14, 2025

View your CI Pipeline Execution ↗ for commit 84e37c0


☁️ Nx Cloud last updated this comment at 2025-07-24 21:49:08 UTC

Base automatically changed from cass-gm-1218 to main July 22, 2025 15:37
Comment on lines 73 to 79
export const FullDataList: Story = {
render: () => <DataListTemplate />,
render: () => (
<Box width="420px">
<DataListTemplate />
</Box>
),
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for testing purposes and will be removed before being shipped

Comment on lines +262 to +263
overflow: 'visible',
width: '1000px',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for testing purposes, will be removed before being shipped

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6882aa69aff08015ecc552f1--gamut-preview.netlify.app

Deploy Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants