Skip to content

feat(ContainerQueries): add container queries to responsive props api #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 22, 2025

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Jul 8, 2025

Overview

Adds container queries to our responsive props API

PR Checklist

  • [n/a ] Related to designs:
  • Related to JIRA ticket: GM-1218
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Go to the Responsive Props story and see the new section
  2. Go the the example and see the changes when you change screensize
  3. Head to mono + monolith and see the passing tests

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

Copy link

nx-cloud bot commented Jul 8, 2025

View your CI Pipeline Execution ↗ for commit dd4a6f4


☁️ Nx Cloud last updated this comment at 2025-07-22 14:51:43 UTC

@dreamwasp dreamwasp marked this pull request as ready for review July 17, 2025 19:32
@dreamwasp dreamwasp requested a review from a team as a code owner July 17, 2025 19:32
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A couple small thoughts

2. **Declare containers** – add `container-type` to the element whose descendants should listen to container breakpoints.
3. **Stay readable** – the same guidelines for choosing object vs. array syntax apply. Use object syntax for isolated container breakpoints and the ordered array syntax when specifying every breakpoint.

Check out the stories in the left sidebar for more examples of responsive props!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link directly to them? Took me a minute to realize there were examples that aren't directly included in the mdx page

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://687fa594f3e4d82c7bd40e91--gamut-preview.netlify.app

Deploy Logs

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Jul 22, 2025
@codecademydev codecademydev merged commit f29d307 into main Jul 22, 2025
21 of 22 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jul 22, 2025
@codecademydev codecademydev deleted the cass-gm-1218 branch July 22, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants