-
Notifications
You must be signed in to change notification settings - Fork 31
feat(ContainerQueries): add container queries to responsive props api #3130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
View your CI Pipeline Execution ↗ for commit dd4a6f4 ☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A couple small thoughts
packages/styleguide/src/lib/Foundations/System/ResponsiveProperties/ResponsiveProperties.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Foundations/System/ResponsiveProperties/ResponsiveProperties.mdx
Outdated
Show resolved
Hide resolved
2. **Declare containers** – add `container-type` to the element whose descendants should listen to container breakpoints. | ||
3. **Stay readable** – the same guidelines for choosing object vs. array syntax apply. Use object syntax for isolated container breakpoints and the ordered array syntax when specifying every breakpoint. | ||
|
||
Check out the stories in the left sidebar for more examples of responsive props! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we link directly to them? Took me a minute to realize there were examples that aren't directly included in the mdx page
…rties/ResponsiveProperties.mdx Co-authored-by: Amy Resnik <[email protected]>
🚀 Styleguide deploy preview ready! |
📬Published Alpha Packages:@codecademy/[email protected] |
Overview
Adds container queries to our responsive props API
PR Checklist
Testing Instructions
PR Links and Envs