Skip to content

docs: added variants to text related buttons #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented May 29, 2025

Overview

Buttons were missing the variant prop in their props table.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GM-1150
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Go to the preview.
  2. Look over StrokeButton, FillButton, and TextButton and see that the variant prop is now added and editable
  3. ...
  4. Profit!

PR Links and Envs

N/A strictly change in StoryBook.

Copy link

nx-cloud bot commented May 29, 2025

View your CI Pipeline Execution ↗ for commit ac7294a.


☁️ Nx Cloud last updated this comment at 2025-06-03 16:00:15 UTC

@LinKCoding LinKCoding changed the title added variants to text related buttons docs: added variants to text related buttons Jun 2, 2025
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://683f1c255366fc10634c89e7--gamut-preview.netlify.app

Deploy Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants