fix: actually fixed dynamic agents heh

Author: brandonkachen

backend/src/templates/agent-registry.ts

@@ -19,9 +19,8 @@ class AgentRegistry {
    * Initialize the registry with a file context (needed for dynamic agent loading)
    */
   async initialize(fileContext: ProjectFileContext): Promise<void> {
-    if (this.isInitialized) {
-      return
-    }
+    // Reset state to ensure fresh loading
+    this.reset()
 
     // Load dynamic agents using the service
     const { templates: dynamicTemplates, validationErrors } =
@@ -80,6 +79,8 @@ class AgentRegistry {
         'Dynamic agent template validation errors'
       )
     }
+
+
   }
 
   /**
@@ -169,6 +170,8 @@ class AgentRegistry {
     this.allAgentNames = {}
     this.isInitialized = false
     this.validationErrors = []
+    // Also reset the dynamic agent service
+    dynamicAgentService.reset()
   }
 }
 

backend/src/templates/dynamic-agent-service.ts

@@ -47,6 +47,8 @@ export class DynamicAgentService {
     const agentTemplates = fileContext.agentTemplates || {}
     const hasAgentTemplates = Object.keys(agentTemplates).length > 0
 
+
+
     if (!hasAgentTemplates) {
       this.isLoaded = true
       return {
@@ -86,13 +88,7 @@ export class DynamicAgentService {
 
     this.isLoaded = true
 
-    const templateCount = Object.keys(this.templates).length
-    if (templateCount > 0 && logger?.info) {
-      logger.info(
-        { templateCount, agentIds: Object.keys(this.templates) },
-        'Dynamic agents loaded successfully'
-      )
-    }
+
 
     return {
       templates: this.templates,

backend/src/websockets/websocket-action.ts

@@ -279,32 +279,26 @@ const onInit = async (
     let allValidationErrors: Array<{ filePath: string; message: string }> = []
 
     if (agentTemplates) {
-      // Load dynamic agent templates first to get their IDs
-      const { validationErrors: dynamicErrors } =
-        await dynamicAgentService.loadAgents(fileContext)
-      allValidationErrors.push(...dynamicErrors)
+      // Initialize agent registry (this will load dynamic agents and handle validation)
+      await agentRegistry.initialize(fileContext)
 
-      if (dynamicErrors.length > 0 && logger?.warn) {
+      // Get validation errors from the registry
+      allValidationErrors = agentRegistry.getValidationErrors()
+
+      if (allValidationErrors.length > 0) {
         logger.warn(
-          { errorCount: dynamicErrors.length },
-          'Dynamic agent validation errors found'
+          { errorCount: allValidationErrors.length },
+          'Agent template validation errors found'
         )
       }
-
-      // Get dynamic agent IDs for override validation
-      const dynamicAgentIds = dynamicAgentService.getAgentTypes()
-      // Validate override templates with dynamic agent IDs
-      const { validationErrors: overrideErrors } = validateAgentTemplateConfigs(
-        agentTemplates,
-        dynamicAgentIds
-      )
-      allValidationErrors.push(...overrideErrors)
+    } else {
+      // Still need to initialize the registry even without agent templates
+      await agentRegistry.initialize(fileContext)
     }
 
     const errorMessage = formatValidationErrorMessage(allValidationErrors)
 
     // Get all agent names (static + dynamic) for frontend
-    await agentRegistry.initialize(fileContext)
     const allAgentNames = agentRegistry.getAllAgentNames()
 
     // Send combined init and usage response

common/src/util/agent-template-validation.ts

@@ -9,7 +9,10 @@ import {
   DynamicAgentTemplateSchema,
 } from '../types/dynamic-agent-template'
 import { AgentTemplateTypes } from '../types/session-state'
-import { normalizeAgentName, normalizeAgentNames } from './agent-name-normalization'
+import {
+  normalizeAgentName,
+  normalizeAgentNames,
+} from './agent-name-normalization'
 
 export interface SpawnableAgentValidationResult {
   valid: boolean