[render preview][codecane] fix: dynamic agents (#208)

Co-authored-by: Codebuff <noreply@codebuff.com>

Author: brandonkachen

.github/workflows/npm-app-release-staging.yml

@@ -134,7 +134,7 @@ jobs:
       new-version: ${{ needs.prepare-and-commit-staging.outputs.new_version }}
       artifact-name: updated-staging-package
       checkout-ref: ${{ github.event.pull_request.head.sha }}
-      env-overrides: '{"NEXT_PUBLIC_CB_ENVIRONMENT": "prod", "NEXT_PUBLIC_BACKEND_URL": "backend-pr-187-cg9u.onrender.com"}'
+      env-overrides: '{"NEXT_PUBLIC_CB_ENVIRONMENT": "prod", "NEXT_PUBLIC_BACKEND_URL": "backend-pr-208-n6sd.onrender.com"}'
     secrets: inherit
 
   # Create GitHub prerelease with all binaries

backend/src/templates/dynamic-agent-service.ts

@@ -48,14 +48,12 @@ export class DynamicAgentService {
     const hasAgentTemplates = Object.keys(agentTemplates).length > 0
 
     if (!hasAgentTemplates) {
-      logger.debug('No agent templates found in fileContext')
       this.isLoaded = true
       return {
         templates: this.templates,
         validationErrors: this.validationErrors,
       }
     }
-
     try {
       // Use agentTemplates from fileContext - keys are already full paths
       const jsonFiles = Object.keys(agentTemplates).filter((filePath) =>
@@ -88,6 +86,14 @@ export class DynamicAgentService {
 
     this.isLoaded = true
 
+    const templateCount = Object.keys(this.templates).length
+    if (templateCount > 0 && logger?.info) {
+      logger.info(
+        { templateCount, agentIds: Object.keys(this.templates) },
+        'Dynamic agents loaded successfully'
+      )
+    }
+
     return {
       templates: this.templates,
       validationErrors: this.validationErrors,
@@ -277,6 +283,7 @@ export class DynamicAgentService {
     } catch (error) {
       const errorMessage =
         error instanceof Error ? error.message : 'Unknown error'
+
       this.validationErrors.push({
         filePath,
         message: `Error in agent template ${filePath}: ${errorMessage}`,
@@ -326,7 +333,6 @@ export class DynamicAgentService {
 
     return ''
   }
-
   /**
    * Convert JSON schema to Zod schema format using json-schema-to-zod.
    * This is done once during loading to avoid repeated conversions.
@@ -396,14 +402,12 @@ export class DynamicAgentService {
 
     return result
   }
-
   /**
    * Get a specific agent template by type
    */
   getTemplate(agentType: string): AgentTemplate | undefined {
     return this.templates[agentType]
   }
-
   /**
    * Get all loaded dynamic agent templates
    */

backend/src/tools/handlers/spawn-agents.ts

@@ -69,10 +69,6 @@ export const handleSpawnAgents = ((params: {
     )
   }
 
-  // Initialize registry and get all templates
-  agentRegistry.initialize(fileContext)
-  const allTemplates = agentRegistry.getAllTemplates()
-
   const conversationHistoryMessage: CoreMessage = {
     role: 'user',
     content: `For context, the following is the conversation history between the user and an assistant:\n\n${JSON.stringify(
@@ -83,6 +79,16 @@ export const handleSpawnAgents = ((params: {
   }
 
   const triggerSpawnAgents = async () => {
+    // Initialize registry and get all templates
+    await agentRegistry.initialize(fileContext)
+    const allTemplates = agentRegistry.getAllTemplates()
+    logger.debug(
+      {
+        availableAgentCount: Object.keys(allTemplates).length,
+        requestedAgents: agents.map((a) => a.agent_type),
+      },
+      'Agent registry initialized for spawning'
+    )
     const results = await Promise.allSettled(
       agents.map(async ({ agent_type: agentTypeStr, prompt, params }) => {
         if (!(agentTypeStr in allTemplates)) {

backend/src/websockets/websocket-action.ts

@@ -284,9 +284,15 @@ const onInit = async (
         await dynamicAgentService.loadAgents(fileContext)
       allValidationErrors.push(...dynamicErrors)
 
+      if (dynamicErrors.length > 0 && logger?.warn) {
+        logger.warn(
+          { errorCount: dynamicErrors.length },
+          'Dynamic agent validation errors found'
+        )
+      }
+
       // Get dynamic agent IDs for override validation
       const dynamicAgentIds = dynamicAgentService.getAgentTypes()
-
       // Validate override templates with dynamic agent IDs
       const { validationErrors: overrideErrors } = validateAgentTemplateConfigs(
         agentTemplates,

npm-app/release-staging/index.js

@@ -22,10 +22,9 @@ function createConfig(packageName) {
     configDir,
     binaryName,
     binaryPath: path.join(configDir, binaryName),
-    githubRepo: 'CodebuffAI/codebuff-community',
+
     userAgent: `${packageName}-cli`,
     requestTimeout: 20000,
-    isPrerelease: true, // codecane always looks for prereleases
   }
 }
 
@@ -70,13 +69,6 @@ function httpGet(url, options = {}) {
       },
     }
 
-    // Add GitHub token if available
-    const token = process.env.GITHUB_TOKEN
-    if (token) {
-      console.log('Using your GITHUB_TOKEN to download the latest version.')
-      reqOptions.headers.Authorization = `Bearer ${token}`
-    }
-
     const req = https.get(reqOptions, (res) => {
       if (res.statusCode === 302 || res.statusCode === 301) {
         return httpGet(new URL(res.headers.location, url).href, options)
@@ -98,44 +90,17 @@ function httpGet(url, options = {}) {
 
 async function getLatestVersion() {
   try {
+    // Use the direct /latest endpoint for stable releases
     const res = await httpGet(
-      `https://github.com/${CONFIG.githubRepo}/releases.atom`
+      `https://registry.npmjs.org/${packageName}/latest`
     )
 
     if (res.statusCode !== 200) return null
 
     const body = await streamToString(res)
+    const packageData = JSON.parse(body)
 
-    // Parse the Atom XML to extract releases
-    const tagMatches = body.match(
-      /<id>tag:github\.com,2008:Repository\/\d+\/([^<]+)<\/id>/g
-    )
-
-    if (!tagMatches) return null
-
-    // Extract all version tags
-    const versions = tagMatches
-      .map((match) => {
-        const tagMatch = match.match(
-          /<id>tag:github\.com,2008:Repository\/\d+\/([^<]+)<\/id>/
-        )
-        return tagMatch ? tagMatch[1].replace(/^v/, '') : null
-      })
-      .filter(Boolean)
-
-    if (versions.length === 0) return null
-
-    // Filter versions based on whether we want prereleases or stable releases
-    const filteredVersions = versions.filter((version) => {
-      const isPrerelease = version.includes('-')
-      return CONFIG.isPrerelease === isPrerelease
-    })
-
-    if (filteredVersions.length === 0) return null
-
-    // Sort and return the latest version
-    filteredVersions.sort(compareVersions)
-    return filteredVersions[filteredVersions.length - 1]
+    return packageData.version || null
   } catch (error) {
     return null
   }
@@ -284,7 +249,9 @@ async function downloadBinary(version) {
     throw new Error(`Unsupported platform: ${process.platform} ${process.arch}`)
   }
 
-  const downloadUrl = `https://github.com/${CONFIG.githubRepo}/releases/download/v${version}/${fileName}`
+  // For now, we get version info from npm but still download binaries from GitHub
+  // TODO: This assumes GitHub releases still exist with the same naming convention
+  const downloadUrl = `https://github.com/CodebuffAI/codebuff-community/releases/download/v${version}/${fileName}`
 
   // Ensure config directory exists
   fs.mkdirSync(CONFIG.configDir, { recursive: true })
@@ -413,14 +380,10 @@ async function checkForUpdates(runningProcess, exitListener) {
       await downloadBinary(latestVersion)
 
       // Restart with new binary - this replaces the current process
-      const newChild = spawn(
-        CONFIG.binaryPath,
-        process.argv.slice(2),
-        {
-          stdio: 'inherit',
-          detached: false,
-        }
-      )
+      const newChild = spawn(CONFIG.binaryPath, process.argv.slice(2), {
+        stdio: 'inherit',
+        detached: false,
+      })
 
       // Set up exit handler for the new process
       newChild.on('exit', (code) => {
@@ -448,13 +411,9 @@ async function main() {
   await ensureBinaryExists()
 
   // Start the binary with codecane argument
-  const child = spawn(
-    CONFIG.binaryPath,
-    process.argv.slice(2),
-    {
-      stdio: 'inherit',
-    }
-  )
+  const child = spawn(CONFIG.binaryPath, process.argv.slice(2), {
+    stdio: 'inherit',
+  })
 
   // Store reference to the exit listener so we can remove it during updates
   const exitListener = (code) => {