Shrink font further on long ward-leader names#357
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
The card's name font size was just 22px down to 20px once names reached 28 characters, which isn't small enough for names like 'Katherine Gilmore-Richardson' (the 'K' was getting clipped at the left edge of the card, per CodeForPhilly#311). Step it down further: 18px at 28+, 16px at 32+, so the longest names still fit inside the card. Closes CodeForPhilly#311. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per @pwolanin's #311. The card font size was just 22px → 20px once a name hit 28 characters, which isn't small enough for names like
Katherine Gilmore-Richardson(the leadingKwas getting clipped past the left edge of the card).Stepped the tiers down further so 28+ char names render at 18px and 32+ char names at 16px. Same right-anchored layout, just smaller text for the long cases.
Closes #311.