Fix event handling bugs and cleanup

[uguratar]

Summary

• use a separate total_toppers event for user counts
• validate user names on registration
• remove socket listeners when components are destroyed

Testing

• npm run lint (fails: tslint: not found)
• npm run test (fails: ng: not found)

[Copilot]

Pull Request Overview

This PR fixes event-handling inconsistencies, adds registration validation, and ensures socket listeners are cleaned up when components are destroyed.

• Introduce a separate total_toppers event for user counts
• Validate currentTopper.name before registering users
• Implement OnDestroy hooks to remove socket listeners in components

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/app/top-main/top-main.component.ts	Implement OnDestroy to remove 'update_toppers' listener
src/app/register/register.component.ts	Add name-check in addUser(), switch to 'total_toppers', cleanup
src/app/chat/chat.component.ts	Add OnDestroy to remove 'message' listener
server.ts	Change initial emit from 'update_toppers' to 'total_toppers'

Comments suppressed due to low confidence (2)

src/app/register/register.component.ts:41

• Accessing this.currentTopper.name may throw if currentTopper is undefined. Initialize currentTopper in ngOnInit() or add a guard to ensure currentTopper is set before use.

    if (!this.currentTopper.name) {

server.ts:35

• Other parts of the server may still emit 'update_toppers'. Ensure all server-side emits and client listeners consistently use 'total_toppers' to prevent mismatches.

  client.emit('total_toppers', totalToppers);

[Copilot]

You're unsubscribing from 'register_failed', but there’s no matching .on('register_failed', ...) listener in this component. Remove this off call or add the corresponding subscription.