Skip to content

Remove the use of NSEvent for lines movement API #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025

Conversation

Bogdan-Belogurov
Copy link
Contributor

Description

Remove the use of NSEvent for the lines movement API, we need to interact through the editor menu.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2025-06-08.at.09.04.02.mov

We need to make interaction through the editor menu
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was initially hesitant to merge this, as eventually I'd like to move in this direction more generally (removing the local monitor and using menu commands). I realized it's a good start in that direction either way so sorry for that delay.

@thecoolwinter thecoolwinter merged commit e955486 into CodeEditApp:main Jun 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants