Skip to content

Made Editor Separators Thicker #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2025

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented May 29, 2025

Description

Added a new split view separator style that results in a thicker separator.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before

image

After

image

…editors depending on its position in the split layout.
@austincondiff
Copy link
Collaborator Author

austincondiff commented May 30, 2025

A few things to note...

In light mode, colors are incorrect and it looks like this in CodeEdit...
image

In Xcode...
image

The outer separators are darker than the center separator, and both colors are too light and are incorrect.

@thecoolwinter did however mention that we may not need this workaround of adding outer separators because he may know of a way to override the size and color properties.

@thecoolwinter
Copy link
Collaborator

Yeah, you can provide a custom NSSplitView subclass that can give a custom thickness and color. I'll send you the source to resolve the required changes with this branches changes. I just made it provide the custom behavior, I didn't find the correct colors.

Screenshot 2025-05-30 at 9 55 02 AM

Screenshot 2025-05-30 at 10 07 53 AM

tom-ludwig
tom-ludwig previously approved these changes Jun 3, 2025
@tom-ludwig tom-ludwig dismissed their stale review June 3, 2025 07:19

Wrong PR

@austincondiff austincondiff requested a review from tom-ludwig June 7, 2025 03:12
@thecoolwinter thecoolwinter merged commit 12f3199 into CodeEditApp:main Jun 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants