Skip to content

Conversation

@GuillaumeLagrange
Copy link
Contributor

No description provided.

@GuillaumeLagrange GuillaumeLagrange force-pushed the build-native-on-arm branch 2 times, most recently from 112bd40 to 43ef801 Compare September 16, 2025 14:10
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 16, 2025

CodSpeed Instrumentation Performance Report

Merging #56 will improve performances by 38.84%

Comparing build-native-on-arm (69c156b) with main (e31ee8b)1

Summary

⚡ 1 improvement
✅ 81 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iterative_fibo_10 423 µs 304.6 µs +38.84%

Footnotes

  1. No successful run was found on main (453da47) during the generation of this report, so e31ee8b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 16, 2025

CodSpeed WallTime Performance Report

Merging #56 will degrade performances by 12.5%

Comparing build-native-on-arm (69c156b) with main (e31ee8b)1

Summary

⚡ 2 improvements
❌ 1 regression
✅ 45 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iterative_fibo_10 420 ns 480 ns -12.5%
test_iterative_fibo_100 720 ns 648 ns +11.11%
test sync baz 10 384 ns 324 ns +18.52%

Footnotes

  1. No successful run was found on main (453da47) during the generation of this report, so e31ee8b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@GuillaumeLagrange GuillaumeLagrange changed the base branch from main to cod-1253-support-perf-profiling-with-vitest September 16, 2025 14:46
@GuillaumeLagrange GuillaumeLagrange marked this pull request as ready for review September 16, 2025 14:47
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 89ea833 to 3655d7e Compare September 16, 2025 16:46
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 3655d7e to 0994dd1 Compare September 16, 2025 16:52
@GuillaumeLagrange GuillaumeLagrange force-pushed the build-native-on-arm branch 4 times, most recently from 4555334 to 787a9df Compare September 17, 2025 09:11
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 0994dd1 to 674b330 Compare September 17, 2025 09:11
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 674b330 to 73ebe23 Compare September 17, 2025 09:22
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 73ebe23 to 6f12002 Compare September 17, 2025 09:30
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 6f12002 to d1fdf74 Compare September 18, 2025 14:43
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from d1fdf74 to 80fa456 Compare September 19, 2025 14:07
@GuillaumeLagrange GuillaumeLagrange force-pushed the build-native-on-arm branch 2 times, most recently from 82cb7ed to cd422bb Compare September 19, 2025 14:16
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 80fa456 to 44a2b8d Compare September 19, 2025 14:20
@GuillaumeLagrange GuillaumeLagrange force-pushed the build-native-on-arm branch 4 times, most recently from 17d20d5 to 4856ca6 Compare September 24, 2025 15:41
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be cleaned up

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-1253-support-perf-profiling-with-vitest branch from 44a2b8d to 453da47 Compare September 26, 2025 09:42
`node-gyp` was being too smart for its own good and was actually falling
back to the local build, which should not be allowed for this test!
Base automatically changed from cod-1253-support-perf-profiling-with-vitest to main September 26, 2025 10:50
@GuillaumeLagrange GuillaumeLagrange merged commit 69c156b into main Sep 26, 2025
16 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the build-native-on-arm branch September 26, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants