Skip to content

removed picontrol for PMP annual cycle and modes of variability #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lee1043 merged 3 commits into from
Oct 14, 2025
Merged

removed picontrol for PMP annual cycle and modes of variability #463

lee1043 merged 3 commits into from
Oct 14, 2025

Conversation

@lee1043
Copy link
Contributor

@lee1043 lee1043 commented Oct 14, 2025 •
edited
Loading

Description

Address #462

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@lee1043 lee1043 added the bug Something isn't working label Oct 14, 2025
@lee1043 lee1043 marked this pull request as ready for review October 14, 2025 01:38
@lee1043 lee1043 requested a review from minxu74 October 14, 2025 01:38
@lee1043 lee1043 linked an issue Oct 14, 2025 that may be closed by this pull request
Filter data for PMP annual cycle calculations #462
Closed
@codecov
Copy link

codecov bot commented Oct 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...mp/src/climate_ref_pmp/diagnostics/annual_cycle.py 62.80% <ø> (ø)
...c/climate_ref_pmp/diagnostics/variability_modes.py 87.17% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lee1043 lee1043 self-assigned this Oct 14, 2025
@lee1043 lee1043 mentioned this pull request Oct 14, 2025
Open
minxu74
minxu74 approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@minxu74 minxu74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lee1043 Thanks a lot for the quick fix. It looks great.

@lee1043 lee1043 merged commit 1993cb2 into main Oct 14, 2025
10 checks passed
@lee1043 lee1043 deleted the pmp-patch branch October 14, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minxu74 minxu74 minxu74 approved these changes

Assignees

@lee1043 lee1043

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filter data for PMP annual cycle calculations

3 participants

@lee1043 @minxu74