Add 2M microphysics to diagnostic EDMF dycoms RF02 #3962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trontrytel
force-pushed
the
aj/diagnostic_edmf_2M
branch
from
be0943e to
a25436c
Compare
sajjadazimi
approved these changes
Aug 21, 2025
| dt, | ||
| ) | ||
| # Aerosol activation | ||
| # TODO - right now I'm hijacking the |
There was a problem hiding this comment.
We can read prescribed aerosol data from artifacts (Merra-2 dataset). For example the function microphysics_wrappers/compute_prescribed_aerosol_properties! reads sea salt and sulfate data and computes their number concentrations and the mean radius of seasalt. In order to use the data we need to pass a list of aerosols in the yml file.
| max( | ||
| 0, | ||
| w_component.( | ||
| Geometry.WVector.(u³ʲ_data_prev_halflevel) |
There was a problem hiding this comment.
I think this is correct! We need to pass the velocity component along gravity and I think this is it.
oalcabes
approved these changes
Aug 21, 2025
ericmpham
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Folks! This PR adds 2-moment microphysics to diagnostic EDMF.
@sajjadazimi - could I ask you to take a look? I wasn't sure about two things:
For the second point I temporarily hijacked two parameters:
seasalt_calibration_coefficient,reference_seasalt_aerosol_mass_concentrationto allow the users to prescribe the assumed mode size and concentration for seasalt aerosol. Once we make the breaking release of CliMA Params I will add proper parameters for it.We do get some clouds and drizzle and the results differ for high and low concentrations. But in the couple of configurations I tried we have been raining out a lot of the water very early on.