-
Notifications
You must be signed in to change notification settings - Fork 24
feat: add P3 ice microphysics model #3959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0c445d7
to
5beb6bb
Compare
@trontrytel @sajjadazimi could you take a quick look at this PR? It's probably not quite ready to merge, but it does successfully take one time step (on my local machine). Let me know if the overall design is reasonable enough to be merged. In future PRs, I aspire to refactor the 2M as to remove the need for |
This change is part of the following stack: Change managed by git-spice. |
f7d5e45
to
9d9d84c
Compare
Feedback from microphysics team: Once this is done,
We want:
|
0e3801b
to
22ade88
Compare
9d9d84c
to
823af6c
Compare
22ade88
to
a973ebb
Compare
f8620b8
to
99ca766
Compare
a973ebb
to
143dfca
Compare
4a2715d
to
fbcac84
Compare
fbcac84
to
8a41dc9
Compare
8a41dc9
to
b09b5c5
Compare
This pull request adds support for the 2-moment microphysics scheme with P3 ice microphysics ("2MP3") to the codebase, including a new test configuration, initial condition, diagnostics, and all required model infrastructure. The changes ensure that the new scheme is handled correctly throughout the precipitation, cache, initial condition, and diagnostic modules, and integrates it into CI and post-processing.
Support for 2MP3 microphysics scheme:
Microphysics2MomentP3
model throughout the codebase, including imports, cache allocation, precipitation tendencies, and diagnostics, enabling full support for the new scheme. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]New test configuration and initial condition:
single_column_precipitation_2MP3_test.yml
), and created the corresponding initial conditionColdPrecipitatingColumn
and state types (PrecipState2MP3
). [1] [2] [3] [4]Continuous integration and post-processing updates:
Parameter infrastructure updates:
microphysics_2mp3_params
for the new scheme. [1] [2]Diagnostics and output compatibility: