Skip to content

Conversation

@GeekCornerGH
Copy link

@GeekCornerGH GeekCornerGH commented Aug 3, 2025

Adds OpenID Connect support.
Had to rewrite some logic to allow the program to fetch the urls from the /.well-known/openid-configuration endpoint.
I've also added tokio crate to store the OIDC config in memory instead of fetching it for every request.
Development was done against Authentik, but it should work with other providers as well!

@GeekCornerGH GeekCornerGH changed the base branch from master to dev August 3, 2025 15:53
@GeekCornerGH GeekCornerGH marked this pull request as draft August 3, 2025 15:54
@GeekCornerGH
Copy link
Author

GeekCornerGH commented Aug 3, 2025

I'll rebase properly asap

@GeekCornerGH GeekCornerGH marked this pull request as ready for review August 3, 2025 16:02
@GeekCornerGH GeekCornerGH force-pushed the feat/oidc branch 2 times, most recently from 73bdfbb to 0adf5fe Compare August 3, 2025 17:49
@Clem-Fern
Copy link
Owner

Hey, thank's a lot for the contribution, I'll try to review soon

@GeekCornerGH
Copy link
Author

If you want, I'm providing a prebuilt image at ghcr.io/geekcornergh/rtabby-web-api

Copy link

@yanranxiaoxi yanranxiaoxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks normal, looking forward to the merge.

@GeekCornerGH
Copy link
Author

@Clem-Fern Are you able to look at the PR?

@Clem-Fern Clem-Fern deleted the branch Clem-Fern:dev December 1, 2025 13:11
@Clem-Fern Clem-Fern closed this Dec 1, 2025
@Clem-Fern Clem-Fern reopened this Dec 1, 2025
Copy link
Owner

@Clem-Fern Clem-Fern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GeekCornerGH, sorry about the delay.
I reviewed and left two comments.

@GeekCornerGH
Copy link
Author

GeekCornerGH commented Dec 26, 2025

Sorry for the delay. I hope you had a wonderful Christmas.
I made a dedicated struct by copying some parts of the Microsoft provider, and I moved the config call to only run when using OIDC.

@GeekCornerGH
Copy link
Author

Just ran cargo fmt because I figured out I forgot to do so

@GeekCornerGH
Copy link
Author

@Clem-Fern happy new year! Are you able to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants