-
Notifications
You must be signed in to change notification settings - Fork 184
chore: create conventional-commit workflow #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Caution Review failedThe pull request is closed. WalkthroughAdds a new GitHub Actions workflow at Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/conventional-commit.yml (1)
1-16: Also validate PR titles if you squash-merge.If merges are squashed, the final commit message comes from the PR title, not individual commits. Add a PR-title semantic check (e.g., amannn/action-semantic-pull-request).
Example additional job:
jobs: semantic-pr-title: permissions: pull-requests: read statuses: write runs-on: ubuntu-latest if: github.event_name == 'pull_request' steps: - uses: amannn/action-semantic-pull-request@v5 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
🧹 Nitpick comments (1)
.github/workflows/conventional-commit.yml (1)
14-14: Consider full history fetch to avoid edge cases.If the action inspects commit history on push, set fetch-depth: 0. Low cost, avoids shallow clone pitfalls.
- - uses: actions/checkout@v4 + - uses: actions/checkout@v4 + with: + fetch-depth: 0
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/conventional-commit.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/conventional-commit.yml (1)
14-15: Pin actions to release commit SHAs; webiny/action-conventional-commits v1.3.0 is current.Pin actions to full commit SHAs for supply‑chain hardening. webiny/action-conventional-commits v1.3.0 is actively maintained (release SHA: 8bc41ff4e7d423d56fa4905f6ff79209a78776c7 — released 2025-05-20). actions/checkout has a v5 release (v5.0.0 SHA: 08c6903cd8c0fde910a37f88322edcfb5dd907a8) — either upgrade to v5 and pin that SHA or pin your current v4 to its release SHA.
File: .github/workflows/conventional-commit.yml
Lines: 14-15Example (replace with the release commit SHA):
- - uses: actions/checkout@v4 + - uses: actions/checkout@<sha> # v4 - - uses: webiny/[email protected] + - uses: webiny/action-conventional-commits@<sha> # v1.3.0
niladrix719
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm

Fixes #631
Fixed #571
This is a precursor for the Release Pipelines
I have added the conventional-commit workflow, This is required for Release notes Automation
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.
Summary by CodeRabbit