Add telemetry enable/disable commands#1301
Open
schurchleycci wants to merge 5 commits into
Open
Conversation
- Fix confirmation message showing wrong path when --config flag is used
- Use strconv.FormatBool instead of fmt.Sprintf("%t") in settings list
- Add unit tests for IsTelemetryEnabled covering env var × stored preference
- Pin TestTelemetryNoArgs assertion to stdout instead of stdout||stderr
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
schurchleycci
force-pushed
the
fact-161/telemetry-commands
branch
from
d552538 to
792eb86
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…etenv in handler - Handle config.Path() error instead of silently discarding it in both enable and disable handlers; pass resolvedPath (not original configPath) to SetTelemetryEnabled so the written path and success message always agree - Unexport NoTelemetryEnvVars → noTelemetryEnvVars; add ActiveTelemetryOverrides() to expose only the currently-set overrides without handing callers a mutable slice - Replace os.Getenv loop in enable handler with config.ActiveTelemetryOverrides(), removing the direct os import from the command layer Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
schurchleycci
changed the title
Contributor
|
This looks good, but I believe we should manage the setting under the |
Author
Good call - so pretty much take what I've got here and put it under e.g. |
Telemetry enable/disable now live at `circleci settings telemetry enable` and `circleci settings telemetry disable` rather than as a top-level command group. Settings imports the telemetry package and registers it as a subcommand; root no longer registers telemetry directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
@pete-woods this is updated to be |
pete-woods
approved these changes
May 14, 2026
| @@ -0,0 +1,90 @@ | |||
| // Copyright (c) 2026 Circle Internet Services, Inc. | |||
Contributor
There was a problem hiding this comment.
These files still look like they need moving.
Stamping, assuming that will be done, though.
Contributor
|
Have stamped under the assumption of moving those files. |
The internal/cmd/telemetry package is removed entirely. The three files are recreated as package settings under internal/cmd/settings/, and settings.go now calls newTelemetryCmd() directly with no cross-package import. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
Ahhh sorry about that, I've clearly been juggling too many Claude sessions. They're fully moved over now rather than duplicated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
circleci settings telemetry enableandcircleci settings telemetry disable. Preference is persisted to the config file; env vars (CIRCLECI_NO_TELEMETRY,NO_ANALYTICS,DO_NOT_TRACK,CI) always win.telemetry_enabledis also surfaced incircleci settings list.Design notes
circleci settings telemetryrather than as a top-level command group — telemetry is a CLI setting, so it belongs alongsidesetandlist--jsonon enable/disable — pure mutation commands; read path is covered bysettings list --json--config), not the XDG defaultTest plan
circleci settings telemetry enable/disablewrite the correct value and print the right pathcircleci --config /tmp/custom.yml settings telemetry enableconfirmation shows/tmp/custom.ymlCIRCLECI_NO_TELEMETRY=1 circleci settings telemetry enablesaves the preference but prints the override noticecircleci settings listand--jsonboth includetelemetry_enabledtask test🤖 Generated with Claude Code