change to unsigned char for isdigit() and friends.#18
Open
nanobug wants to merge 2 commits intoCieNTi:masterfrom
Open
change to unsigned char for isdigit() and friends.#18nanobug wants to merge 2 commits intoCieNTi:masterfrom
nanobug wants to merge 2 commits intoCieNTi:masterfrom
Conversation
use unsigned char, else the isdigit() and friends might assert !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the received characters might be way off(corrupted RX), This will result in *temp to be for example 0xf0. There is an assert in the debug build for this. This might result in hang of release application.