Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the application state management and proxy logic to improve code organization and maintainability. The main goals are separating concerns between server, proxy, and cache management components.
- Creates a centralized
AppStatestruct to hold shared application state including database pools, job cache, and worker health monitoring - Extracts proxy startup logic from main.rs into the proxy module for better separation of concerns
- Moves cache synchronization functionality into a dedicated cache module
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/app_state.rs | New module defining AppState struct with initialization logic |
| server/src/cache.rs | New module containing job cache management and sync functionality |
| server/src/main.rs | Simplified main function using AppState, moved proxy logic to proxy module |
| server/src/routes/*.rs | Updated route handlers to use AppState instead of individual dependencies |
| proxy/src/proxy.rs | Added start_postgres_proxy function moved from main.rs |
| extension/src/*.rs | Minor code cleanup removing deprecated functions and dead code |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.