Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements operators support in server filters, allowing search queries to use comparison operators like eq., gt., gte., lt., and lte. with filter values. The implementation includes comprehensive SQL injection protection, maintains backward compatibility with existing filters, and adds extensive test coverage.
- Complete redesign of the
FilterValuetype system to support operators with type-safe value parsing - Implementation of SQL injection protection through pattern detection and input validation
- Addition of comprehensive test suite covering normal operations, edge cases, and security scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| server/tests/util.rs | Updated error handling to return Result types instead of panicking |
| server/tests/tests.rs | Added extensive test coverage for filter operators including backward compatibility and edge cases |
| server/src/routes/search.rs | Updated to use new FilterValue structure and handle different value types in query binding |
| core/src/query.rs | Major refactoring with new operator system, SQL injection protection, and comprehensive test suite |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To search such as
query=iphones&product_category=eq.electronics&price=lte.1000for iphones in electronics less than or equal to 1000 price.