fix(wizard): clean up done-state banner and node-routed catalog form#608
Merged
fix(wizard): clean up done-state banner and node-routed catalog form#608
Conversation
c0b47ed to
914f706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doneorcancelledstage. Heartbeat loss in those states is expected (the CLI process exits cleanly after/api/proxy/complete), and showing the red banner on top of the success screen made users think creation had failed.CustomServiceForm's via-node behavior intoCatalogConfirmForm. When the wizard is launched with--via-node, the catalog form now hides the credential input, surfaces a "Routed via node" badge, and submits without acredentialfield — matching the backend contract that node-routed services authorize on the node agent.closes #595
closes #602
Test plan
cd frontend && npm run lint && npm run test && npm run buildcd frontend && npm run build:wizardcargo test -p nyxid-cli --test wizard_bundle_freshnessConnection to CLI interrupted#595: trigger a successful service-add vianyxid service add llm-openai, confirm the success screen no longer shows the "Connection to CLI interrupted" banner once the CLI exits.service add <slug> --via-nodestill asks for an API key in browser wizard and fails with node-managed credential error #602:nyxid service add llm-openai --via-node <node-id>, confirm the wizard shows the node badge instead of the API key field, and the submit button reads "Connect via node" and produces anode_managedservice.