fix(wizard): polish custom-service form labels and step header#607
Merged
fix(wizard): polish custom-service form labels and step header#607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*plusaria-required) to Label, Endpoint URL, Auth method, and the dynamic credential label in the CLI Wizard's Custom / self-hosted service form. Optional fields (Custom slug, dynamic auth-key-name) are unchanged.cli/tests/wizard_bundle_freshness.rsstays green.closes #594
closes #603
Test plan
cd frontend && npm run lint && npm run test && npm run buildcd frontend && npm run build:wizard(verify the committed bundle hash is unchanged afterwards)cargo test -p nyxid-cli --test wizard_bundle_freshnessnyxid service add --custom, confirm Label / Endpoint URL / Auth method / credential labels show*and the slug field stays "(optional)".none, confirm the credential field disappears entirely.