fix: harden WORKFLOW.md with symphony patterns and mempalace#259
Merged
fix: harden WORKFLOW.md with symphony patterns and mempalace#259
Conversation
- Use python3 -m mempalace instead of bare mempalace binary (pip install
puts the binary outside PATH on most systems)
- Make mempalace mandatory in hooks: after_create mines project, before_run
loads context, after_run stores coordination artifacts
- Add {{ default_prompt }} to triage and reviewer stage prompts so they
inherit the base prompt (Non-Negotiable Rules, Architecture Rules,
Workpad, Git rules, Coordination surface, Final Checklist)
- Add state_instructions and role_instructions for code-review/rework
- Add missing terminal states (Canceled, Duplicate)
- Fix codex read_timeout_ms 5000 -> 30000 to prevent handshake timeouts
- Add turn_sandbox_policy to codex agent config
- Add --depth 1 to git clone for faster workspace creation
- Adopt hardened prompt contracts from chronoai-symphony: Mission with
explicit stop conditions, Non-Negotiable Rules, Status Map, State
Routing, Execution/Review/Rework Contracts, Blockers and Handoff
The validator requires every runnable stage sharing a state to define a scope. The implementer fallback shares 'in-progress' with backend-implementer and frontend-implementer, so it needs scope: ./
The validator rejects root scope (./) for parallel pipeline stages. The fullstack implementer now requires a `fullstack` label from triage (mutually exclusive with backend/frontend labels) and uses a non-root scope. Triage prompt updated to always assign one routing label.
The after_create hook fails on cold Rust builds that exceed the 300s timeout. Increase to 600s. Also wrap cd commands in subshells so the working directory stays at repo root for mempalace commands.
The cargo build in after_create is only a cache-warm — the real build runs in before_run after branch checkout. A compile failure in after_create should not prevent workspace creation since the agent needs the workspace to exist before it can do anything.
The triage agent was implementing fixes instead of just labeling and
handing off. The base prompt's Execution Contract tells agents to
"make changes that resolve your role's responsibility" which the
triage agent interpreted as writing code. Added explicit boundaries
before {{ default_prompt }} to override that behavior.
Same issue as triage — the base prompt's Execution Contract tells agents to make changes, which the reviewer could interpret as writing fixes. Added boundaries: review only, no code, no commits.
Codex app-server handshake consistently times out at 30s. Increase to 60s for both agents. Also add explicit read_timeout_ms and stall_timeout_ms to the claude profile (was relying on defaults). Note: the immediate Codex failure is likely due to missing OPENAI_API_KEY — the process launches but produces zero output.
Codex v0.118.0 changed sandboxPolicy from a plain string to an internally tagged enum. Sending "danger-full-access" as a string now fails with: invalid type: string, expected internally tagged enum SandboxPolicy. Remove both thread_sandbox and turn_sandbox_policy so Symphony uses its structured defaults (workspaceWrite with full network access).
Agents need explicit instructions to use mempalace — having the MCP server connected is not enough. Added: - before_run: generate wake-up context (L0+L1) via `mempalace wake-up` - Prompt template: MemPalace section with instructions for session start (read wakeup + context files), during work (search before deciding), and session end (store decisions and patterns) - Agents now know to use mempalace_search, mempalace_kg_query, mempalace_diary_write, mempalace_add_drawer, and mempalace_kg_add
Without thread_sandbox: danger-full-access, Codex cannot write to .git/ (index.lock permission denied). Symphony now translates this to the tagged enum format Codex v0.118.0 expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python3 -m mempalace(bypasses PATH issue with pip install), wake-up context (L0+L1), and explicit agent instructions for search/store{{ default_prompt }}to triage and reviewer stage prompts so they inherit the base prompt, with CRITICAL role boundaries to prevent non-implementer agents from writing codethread_sandbox: danger-full-accessfor git access, removeturn_sandbox_policystring (Codex v0.118.0 rejects it, Symphony now translates internally)when_labels: [fullstack]with non-root scopestate_instructionsandrole_instructionsfor code-review/rework overlaysread_timeout_ms: 60000, explicitstall_timeout_mson claude profilecd, non-fatal build inafter_create, timeout 300s -> 600sTest plan