Gaussian Elimination and back-substitution algorithm#1
Open
istonevol wants to merge 19 commits intoChristopher42:masterfrom
Open
Gaussian Elimination and back-substitution algorithm#1istonevol wants to merge 19 commits intoChristopher42:masterfrom
istonevol wants to merge 19 commits intoChristopher42:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To Christopher Johnson,
Hello, I am a computer science major and mathematics minor at the University of Tennessee. I am currently taking a software development class and one of our assignments is to submit a pull request to an existing project on GitHub. Fortunately I was lucky enough to stumble across your computational-mathematics repository. It is excellent reference material for different algorithms, contains lots of useful tools, and is well documented. However, I noticed that in your iterative matrix solver kit, you do not have a Gaussian Elimination algorithm. I am aware that Gauss Seidel Method can be accurate in even after few iterations, but a guess of vector x is required. Gauss Elimination and back-substitution requires only the matrix and mine will be able to tell you if it is not solvable. My submission and documentation is yours to use/modify as you wish and will hopefully be another addition to your growing project. I have submitted a pull request containing a few things: A .h file and a .cpp file to implement a Gaussian Elimination and back-substitution algorithm( I tried to get close to your style and formatting ), and a separate folder containing a project to test them( which should be ready to compile ). Please take a look if you have time and feel free to let me know if you have any issues. Thank you.
Sincerely,
Isaac Stone
UTK Computer Science Undergrad
Note: Some of the files I included in the folder are yours that you wrote and I included them for easy compilation. None of your files were modified. Though I did have to comment some lines from iterativeSolvers.cpp and iterativeSolvers.h in order for mine to compile.