Skip to content

Conversation

@dmpe
Copy link
Contributor

@dmpe dmpe commented Nov 18, 2015

#64 (comment)
this now takes care of:

read.socrata(url = "https://data.cityofchicago.org/Health-Human-Services/Food-Inspections/4ijn-s7e5") generates an error because of the rowCount line. Specifically, I'm trying to understand the grander concept around getMetadata(), which is trying to fetch a lot of information, but is using little of it. Does it make sense to just keep it simple to help troubleshooting?

@dmpe dmpe changed the title rowCount line Replace getMetadata for row count with getQueryRowCount (which uses =COUNT(*)) Dec 24, 2015
@dmpe dmpe closed this Dec 24, 2015
@dmpe dmpe reopened this Dec 24, 2015
@dmpe dmpe force-pushed the dev branch 3 times, most recently from f8b901c to 226eb7c Compare December 24, 2015 20:49
@dmpe
Copy link
Contributor Author

dmpe commented Dec 24, 2015

Hi @tomschenkjr,
After having totally messed up with this PR, I tried to recreate a lot which I have both committed (in the PR) and what has been in the repository before.

Yeeh, most probably total mess. But, on the other hand, I fixed the error message with the one about curl and that the host could not have been resolved. :)

Let me know how can I help more in order to merge this PR. (I guess, you cannot merge it, right ?)

@tomschenkjr
Copy link
Contributor

So, I'd like to propose that we step back a bit and increment through these new features a bit more incrementally. We can add a feature and make a pull request before moving onto the next one--break-up the larger pull request into smaller ones. I've opened a Gitters forum, which will let us discuss this a little more easily.

I am thinking we work on features in these order:

  1. Add the ability to upload data sets (this will require the username and password parameter be added to arguments).
  2. Add ability to download geojson data.

To get ready for this, I would recommend:

  • We can set the DESCRIPTION file to Version: 1.7.0-1 and with each build, get to Version: 1.7.0-x for ever how many x builds it'll take to get to a stable version with these new features.
    *. Rebase the dev branch with the current master--stable--code as the starting point.

We should chat through this, though, to make sure it makes sense. If everyone is interested in this approach, jump into the forum and we can plan it out. We'll have to redo some of this work, but I think it's needed.

CC'ing @marks and @geneorama

@marks
Copy link

marks commented Dec 25, 2015

@tomschenkjr @dmpe - this (and nearly anything you all would decide) is completely A-OK with me. As I said in the Gitter channel:

I am 100% cool with whatever you all decide. Just let me know when I should submit my changes (sounds like it may be easier to pull down the stable dev branch you all will create and re-do my changes, not a big deal).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants